From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192
Date: Tue, 16 Dec 2014 17:01:38 +0100 [thread overview]
Message-ID: <20141216170138.14dcabc1@free-electrons.com> (raw)
In-Reply-To: <20141215203724.GA22936@anne>
Dear Evgeni Dobrev,
On Mon, 15 Dec 2014 21:37:24 +0100, Evgeni Dobrev wrote:
> This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor.
Commit log text should be wrapped to some reasonable length.
> interrupts = <21>;
> clocks = <&gate_clk 14>, <&gate_clk 15>;
> clock-names = "0", "1";
> + phys = <&sata_phy0>, <&sata_phy1>;
> + phy-names = "port0", "port1";
You should use tabs and not spaces for indentation in Device Tree files.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-16 16:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 20:37 [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192 Evgeni Dobrev
2014-12-16 8:19 ` Andrew Lunn
2014-12-16 13:46 ` Sergei Shtylyov
2014-12-16 16:01 ` Thomas Petazzoni [this message]
[not found] ` <20141216170138.14dcabc1-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-12-16 18:19 ` Evgeni Dobrev
2014-12-16 18:21 ` [PATCH v2 0/1] " Evgeni Dobrev
2014-12-16 18:22 ` [PATCH v2 1/1] " Evgeni Dobrev
2014-12-21 12:43 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216170138.14dcabc1@free-electrons.com \
--to=thomas.petazzoni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).