From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Evgeni Dobrev <evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Sebastian Hesselbarth
<sebastian.hesselbarth-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] ARM: dts: kirkwood: add dts support for Seagate BlackArmor NAS220
Date: Tue, 16 Dec 2014 20:20:20 +0100 [thread overview]
Message-ID: <20141216192020.GB12820@lunn.ch> (raw)
In-Reply-To: <20141216163714.GE20170@anne>
> The LED can be either one of the two colors or off. Swapping the
> polarity on the two LED pins changes the color.
O.K, so it is using the diode property of a Light Emitting Diode, to
support two colours.
> I am currently playing with the idea to create a multicolor LED kernel
> driver which is being controlled via GPIOs, but I still have not found
> the proper abstraction for it.
Maybe multi-colour is too far. Just support bi-colour via two gpios.
Still, it is not so simple. As you said, the led class does not give
too good an abstraction. I guess the best you can do is that when you
turn one on, it automagically turns the other off.
> The point is, that even though this functionality must currently be
> handled by user space (some combination of sysfs writes and a shell
> script) at the moment, the rest of the system is usable.
Sure, we will take the DT file without support for the bicolour
LED. It can be added later.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-16 19:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 20:38 [PATCH 2/2] ARM: dts: kirkwood: add dts support for Seagate BlackArmor NAS220 Evgeni Dobrev
2014-12-16 8:56 ` Andrew Lunn
2014-12-16 16:37 ` Evgeni Dobrev
2014-12-16 19:20 ` Andrew Lunn [this message]
2014-12-22 8:04 ` [PATCH v2 0/1] add " Evgeni Dobrev
2014-12-22 8:04 ` [PATCH v2 1/1] " Evgeni Dobrev
2014-12-22 10:02 ` Andrew Lunn
2014-12-22 12:57 ` [PATCH v3 0/1] " Evgeni Dobrev
2014-12-22 12:57 ` [PATCH v3 1/1] " Evgeni Dobrev
2014-12-23 11:31 ` Andrew Lunn
2014-12-25 13:08 ` Sebastian Hesselbarth
2014-12-25 13:31 ` Andrew Lunn
2014-12-25 13:43 ` Sebastian Hesselbarth
2014-12-25 14:12 ` Andrew Lunn
2014-12-25 15:19 ` Sebastian Hesselbarth
[not found] ` <549C0C3C.8060601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-26 11:06 ` Evgeni Dobrev
2014-12-28 10:46 ` [PATCH v4 0/1] " Evgeni Dobrev
2014-12-28 10:46 ` [PATCH v4 1/1] " Evgeni Dobrev
2015-01-05 18:05 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216192020.GB12820@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=evgeni-c3HRhe8yoGxdzLpqerNdyw@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sebastian.hesselbarth-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).