From: Lee Jones <lee.jones@linaro.org>
To: gyungoh@gmail.com
Cc: sameo@linux.intel.com, grant.likely@linaro.org,
robh+dt@kernel.org, jg1.han@samsung.com, cooloney@gmail.com,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
trivial@kernel.org, akpm@linux-foundation.org, jic23@kernel.org,
thomas.petazzoni@free-electrons.com, ktsai@capellamicro.com,
hs@denx.de, stwiss.opensource@diasemi.com,
matti.vaittinen@nsn.com, broonie@kernel.org,
jason@lakedaemon.net, heiko@sntech.de, shawn.guo@freescale.com,
florian.vaussard@epfl.ch, andrew@lunn.ch,
antonynpavlov@gmail.com, hytszk@gmail.com, plagnioj@jcrosoft.com,
tomi.valkeinen@ti.com, jack.yoo@skyworksinc.com,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v10 4/6] devicetree: backlight: Add new SKY81452 backlight binding
Date: Thu, 18 Dec 2014 08:30:36 +0000 [thread overview]
Message-ID: <20141218083036.GR13885@x1> (raw)
In-Reply-To: <1418881671-3495-5-git-send-email-jack.yoo@skyworksinc.com>
DT Ack please.
> From: Gyungoh Yoo <jack.yoo@skyworksinc.com>
>
> Signed-off-by: Gyungoh Yoo <jack.yoo@skyworksinc.com>
> Acked-by: Bryan Wu <cooloney@gmail.com>
> ---
[...]
> Changes v8:
> Renamed property names for backlight with vendor prefix
> Modified gpio-enable property to generic property for GPIO
> Made up the example for backlight DT
[...]
> Changes v2:
> Added reg attribute for I2C slave address
>
> .../video/backlight/sky81452-backlight.txt | 29 ++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> new file mode 100644
> index 0000000..8daebf5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/video/backlight/sky81452-backlight.txt
> @@ -0,0 +1,29 @@
> +SKY81452-backlight bindings
> +
> +Required properties:
> +- compatible : Must be "skyworks,sky81452-backlight"
> +
> +Optional properties:
> +- name : Name of backlight device. Default is 'lcd-backlight'.
> +- gpios : GPIO to use to EN pin.
> + See Documentation/devicetree/bindings/gpio/gpio.txt
> +- skyworks,en-channels : Enable mask for current sink channel 1 to 6.
> +- skyworks,ignore-pwm : Ignore both PWM input
> +- skyworks,dpwm-mode : Enable DPWM dimming mode, otherwise Analog dimming.
> +- skyworks,phase-shift : Enable phase shift mode
> +- skyworks,ovp-level : Over-voltage protection level.
> + Should be between 14 or 28V.
> +- skyworks,short-detection-threshold : It should be one of 4, 5, 6 and 7V.
> +- skyworks,current-limit : It should be 2300mA or 2750mA.
These need a DT Ack (if they are still alive).
> +Example:
> +
> + backlight {
> + compatible = "skyworks,sky81452-backlight";
> + name = "pwm-backlight";
> + skyworks,en-channels = <0x3f>;
> + skyworks,ignore-pwm;
> + skyworks,phase-shift;
> + skyworks,ovp-level = <20>;
> + skyworks,current-limit = <2300>;
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-12-18 8:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 5:47 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1418881671-3495-1-git-send-email-jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org>
2014-12-18 5:47 ` [PATCH v10 1/6] mfd: Add support for Skyworks SKY81452 driver gyungoh-Re5JQEeQqe8AvxtiuMwx3w
2014-12-18 5:47 ` [PATCH v10 2/6] backlight: Add support Skyworks SKY81452 backlight driver gyungoh
[not found] ` <1418881671-3495-3-git-send-email-jack.yoo-tjhQNA90jdKqndwCJWfcng@public.gmane.org>
2014-12-18 6:09 ` Jingoo Han
[not found] ` <001101d01a89$2a629590$7f27c0b0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-12-18 6:13 ` Gyungoh Yoo
2014-12-18 5:47 ` [PATCH v10 3/6] devicetree: mfd: Add new SKY81452 mfd binding gyungoh
2014-12-18 8:32 ` Lee Jones
2014-12-18 5:47 ` [PATCH v10 4/6] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2014-12-18 8:30 ` Lee Jones [this message]
2014-12-18 5:47 ` [PATCH v10 5/6] devicetree: Add vendor prefix for Skyworks Solutions, Inc gyungoh
2014-12-18 8:29 ` Lee Jones
2014-12-18 5:47 ` [PATCH v10 6/6] devicetree: i2c: Add SKY81452 to the Trivial Devices list gyungoh
-- strict thread matches above, loose matches on Subject: below --
2015-01-07 2:19 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh
2015-01-07 2:19 ` [PATCH v10 4/6] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
2015-01-09 1:31 ` Gyungoh Yoo
2014-12-03 7:05 [PATCH v10 0/6] Add Skyworks SKY81452 device drivers gyungoh-Re5JQEeQqe8AvxtiuMwx3w
2014-12-03 7:05 ` [PATCH v10 4/6] devicetree: backlight: Add new SKY81452 backlight binding gyungoh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141218083036.GR13885@x1 \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=antonynpavlov@gmail.com \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gyungoh@gmail.com \
--cc=heiko@sntech.de \
--cc=hs@denx.de \
--cc=hytszk@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jack.yoo@skyworksinc.com \
--cc=jason@lakedaemon.net \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=ktsai@capellamicro.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matti.vaittinen@nsn.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
--cc=shawn.guo@freescale.com \
--cc=stwiss.opensource@diasemi.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tomi.valkeinen@ti.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).