From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 02/13] pinctrl: sun6i: Add A31s pinctrl support Date: Fri, 19 Dec 2014 19:20:11 +0100 Message-ID: <20141219182011.GS4820@lukather> References: <1418836704-15689-1-git-send-email-hdegoede@redhat.com> <1418836704-15689-3-git-send-email-hdegoede@redhat.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UFRfxei4j9xfgtfb" Return-path: Content-Disposition: inline In-Reply-To: <1418836704-15689-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Linus Walleij , Lee Jones , Samuel Ortiz , Mike Turquette , Linux Media Mailing List , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --UFRfxei4j9xfgtfb Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Wed, Dec 17, 2014 at 06:18:13PM +0100, Hans de Goede wrote: > The A31s is a stripped down version of the A31, as such it is missing some > pins and some functions on some pins. > > The new pinctrl-sun6i-a31s.c this commit adds is a copy of pinctrl-sun6i-a31s.c I guess you meant pinctrl-sun6i-a31.c for the second one, right? > with the missing pins and functions removed. > > Note there is no a31s specific version of pinctrl-sun6i-a31-r.c, as the > prcm pins are identical between the A31 and the A31s. > > Signed-off-by: Hans de Goede Acked-by: Maxime Ripard We should probably refactor it at some point like mvebu does though to deal with similar pin sets like this and the A31. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --UFRfxei4j9xfgtfb--