From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
magnus.damm@gmail.com, linux@arm.linux.org.uk,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7790: add MLB+ clock
Date: Tue, 23 Dec 2014 09:23:53 +0900 [thread overview]
Message-ID: <20141223002353.GD2817@verge.net.au> (raw)
In-Reply-To: <54989071.2060509@cogentembedded.com>
Hi Sergei,
On Tue, Dec 23, 2014 at 12:43:13AM +0300, Sergei Shtylyov wrote:
> On 12/22/2014 03:06 AM, Simon Horman wrote:
>
> >>From: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
>
> >>Add MLB+ clock to R8A7790 device tree.
>
> >>Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> >>[Sergei: rebased, renamed, added changelog]
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >>---
> >>This patch is against 'renesas-devel-20141218-v3.18' tag of Simon Horman's
> >>'renesas.git' repo.
>
> >Thanks, I have queued this up.
>
> Oops, just saw a formatting issue in this patch...
>
> [...]
> >>Index: renesas/include/dt-bindings/clock/r8a7790-clock.h
> >>===================================================================
> >>--- renesas.orig/include/dt-bindings/clock/r8a7790-clock.h
> >>+++ renesas/include/dt-bindings/clock/r8a7790-clock.h
> >>@@ -97,6 +97,7 @@
> >> #define R8A7790_CLK_LVDS0 26
> >>
> >> /* MSTP8 */
> >>+#define R8A7790_CLK_MLB 2
>
> Need one more tab here.
>
> >> #define R8A7790_CLK_VIN3 8
> >> #define R8A7790_CLK_VIN2 9
> >> #define R8A7790_CLK_VIN1 10
>
> Perhaps you still can fix it up, or I can resend? I'm not seeing this
> patch in the 'devel' branch yet...
Thanks for following up on this.
I had the patch queued up locally but it seems that I forgot to push them.
I have fixed up this patch by adding an extra tab and pushed the result.
The result should be in renesas-devel-20141223-v3.19-rc1
(But kernel.org seems slow today).
Please let me know if I messed things up somehow.
prev parent reply other threads:[~2014-12-23 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 20:41 [PATCH] ARM: shmobile: r8a7790: add MLB+ clock Sergei Shtylyov
2014-12-22 0:06 ` Simon Horman
2014-12-22 21:43 ` Sergei Shtylyov
2014-12-23 0:23 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141223002353.GD2817@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).