devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Pali Rohar" <pali.rohar@gmail.com>,
	"Jean Delvare" <jdelvare@suse.de>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Tony Lindgren" <tony@atomide.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	lm-sensors@lm-sensors.org, devicetree@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>
Subject: Re: [PATCH 2/3] hwmon: Driver for OMAP3 temperature sensor
Date: Sat, 27 Dec 2014 20:24:31 +0100	[thread overview]
Message-ID: <20141227192431.GC10007@amd> (raw)
In-Reply-To: <1419597294-21487-3-git-send-email-sre@kernel.org>

Hi!


> OMAP34xx and OMAP36xx processors contain a register in the syscon area,
> which can be used to determine the SoCs temperature. This patch provides
> a DT based driver for the temperature sensor based on an older driver
> written by Peter De Schrijver for the Nokia N900 and N9.
> 
> Signed-off-by: Sebastian Reichel <sre@kernel.org>

I did clk_enable -> clk_prepare_enable conversion, as described in
another email.

I got occasional error reading:

root@n900:~# cat /sys/class/hwmon/hwmon0/device/temp_input
20.0
root@n900:~# cat /sys/class/hwmon/hwmon0/device/temp_input
cat: /sys/class/hwmon/hwmon0/device/temp_input: Input/output error
root@n900:~# cat /sys/class/hwmon/hwmon0/device/temp_input
20.0

Nothing in dmesg. It takes few tries to reproduce..

On other attempt, it hung hard:

root@n900:~# cat /sys/class/hwmon/hwmon0/device/temp_input ; cat
/sys/class/hwmon/hwmon0/device/temp_input  ;cat
/sys/class/hwmon/hwmon0/device/temp_input ; cat
/sys/class/hwmon/hwmon0/device/temp_input
17.0
17.0
^[[A



^Z


^C^C^C

Best regards,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2014-12-27 19:24 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20141226102933.GA28778@amd>
2014-12-26 12:34 ` [PATCH 0/3] OMAP3 temperature sensor Sebastian Reichel
2014-12-26 12:34   ` [PATCH 1/3] DT Binding for omap3 " Sebastian Reichel
     [not found]     ` <1419597294-21487-2-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-26 17:19       ` Pavel Machek
2014-12-26 23:50         ` Sebastian Reichel
2014-12-27 19:09       ` Pavel Machek
2014-12-26 12:34   ` [PATCH 2/3] hwmon: Driver for OMAP3 " Sebastian Reichel
2014-12-26 17:26     ` Pavel Machek
2014-12-27 19:24     ` Pavel Machek [this message]
2014-12-27 19:40     ` Pavel Machek
2014-12-27 19:48     ` Pavel Machek
     [not found]     ` <1419597294-21487-3-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-27 19:58       ` Pavel Machek
2014-12-27 22:35         ` Pavel Machek
2014-12-28  8:24           ` Guenter Roeck
2014-12-28 10:07             ` Sebastian Reichel
2014-12-29 17:52       ` Grazvydas Ignotas
2014-12-29 18:01         ` Nishanth Menon
     [not found]           ` <CAGo_u6qO0ok+GBnm7SQtw6dJuwGN2OuP7CpKDEWawS3V2go4KA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-12-29 18:15             ` Pavel Machek
2014-12-29 19:04               ` Guenter Roeck
     [not found]                 ` <20141229190448.GA27124-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2014-12-30 22:46                   ` Pavel Machek
2015-01-01  9:11                 ` Pavel Machek
2015-01-03  9:18                 ` Pavel Machek
2015-01-07 16:19                   ` Guenter Roeck
2015-01-18 20:33                     ` Pavel Machek
2015-01-18 22:18                       ` Guenter Roeck
2014-12-29 20:35               ` Nishanth Menon
     [not found]                 ` <54A1BB2B.9060204-l0cyMroinI0@public.gmane.org>
2014-12-30 18:00                   ` Pavel Machek
2014-12-27 23:26     ` Pavel Machek
2014-12-26 12:34   ` [PATCH 3/3] ARM: dts: OMAP34xx/36xx: Add " Sebastian Reichel
     [not found]     ` <1419597294-21487-4-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-12-27 19:09       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141227192431.GC10007@amd \
    --to=pavel@ucw.cz \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jdelvare@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mark.rutland@arm.com \
    --cc=pali.rohar@gmail.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).