From: Mark Brown <broonie@kernel.org>
To: Andrew Jackson <andrew.jackson@arm.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Rajeev Kumar <rajeevkumar.linux@gmail.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Arnd Bergmann <arnd@arndb.de>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-arm-kernel@lists.infradead.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use
Date: Tue, 30 Dec 2014 16:51:10 +0000 [thread overview]
Message-ID: <20141230165110.GK17800@sirena.org.uk> (raw)
In-Reply-To: <faa0193d388fe808c2fae461954bb1730ba29244.1419936132.git.Andrew.Jackson@arm.com>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
On Tue, Dec 30, 2014 at 10:55:44AM +0000, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@arm.com>
>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.
Applied, though the changelog is inaccurate - the need to do things
outside of hardirq context is the reason the common clock API has a
prepare stage but it's just a flat out requirement of the common clock
API to prepare clocks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-30 16:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 10:55 [PATCH v5 0/6] ASoC: dwc: Add device tree support to designware I2S Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 1/6] ASoC: dwc: Switch to managed clock resource Andrew Jackson
[not found] ` <af6e23a9f11ead4b8abd1f70dbf634964253b37f.1419936132.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-30 16:49 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 2/6] ASoC: dwc: Prepare clock before use Andrew Jackson
2014-12-30 12:39 ` Sergei Shtylyov
2014-12-30 16:51 ` Mark Brown [this message]
2014-12-30 10:55 ` [PATCH v5 3/6] ASoC: dwc: Read I2S block configuration from registers Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 4/6] ASoC: dwc: Register components with managed interface Andrew Jackson
2014-12-30 10:55 ` [PATCH v5 5/6] ASoC: dwc: Add documentation for I2S DT Andrew Jackson
2014-12-30 16:52 ` Mark Brown
2014-12-30 10:55 ` [PATCH v5 6/6] ASoC: dwc: Add devicetree support for Designware I2S Andrew Jackson
[not found] ` <8da45b000fb1f9a029b30fcf5abe50941f45e32e.1419936132.git.Andrew.Jackson-5wv7dgnIgG8@public.gmane.org>
2014-12-30 16:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141230165110.GK17800@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Liviu.Dudau@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew.jackson@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rajeevkumar.linux@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).