From: Sascha Hauer <s.hauer@pengutronix.de>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: mediatek: dts: Add uart to Aquaris5
Date: Mon, 5 Jan 2015 13:28:49 +0100 [thread overview]
Message-ID: <20150105122849.GF4544@pengutronix.de> (raw)
In-Reply-To: <1420224485-11043-3-git-send-email-matthias.bgg@gmail.com>
Hi Matthias,
On Fri, Jan 02, 2015 at 07:48:05PM +0100, Matthias Brugger wrote:
> This patch enables uart port for the Aquaris5 mobile phone.
>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> arch/arm/boot/dts/mt6589-aquaris5.dts | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/mt6589-aquaris5.dts b/arch/arm/boot/dts/mt6589-aquaris5.dts
> index 0da0470..d5cbfda 100644
> --- a/arch/arm/boot/dts/mt6589-aquaris5.dts
> +++ b/arch/arm/boot/dts/mt6589-aquaris5.dts
> @@ -21,10 +21,16 @@
> compatible = "mundoreader,bq-aquaris5", "mediatek,mt6589";
>
> chosen {
> - bootargs = "earlyprintk";
> + bootargs = "console=ttyS0,921600n8 earlyprintk";
> };
stdout-path = &uart0;
Should work aswell and makes you independent from the way the kernel
decides to number the UARTs.
>
> memory {
> reg = <0x80000000 0x40000000>;
> };
> +
> + soc {
> + uart0: serial@11006000 {
> + status = "okay";
> + };
> + };
By using the & notation you don't have to resemble the tree structure in
the board file, like this:
&uart0 {
status = "okay";
};
See for example the omap, i.MX or other dts files.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2015-01-05 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 18:48 [PATCH 0/2] ARM: mediatek: Enable uart for mt6589 Matthias Brugger
2015-01-02 18:48 ` [PATCH 1/2] ARM: mediatek: dts: Add uart to mt6589 Matthias Brugger
2015-01-02 18:48 ` [PATCH 2/2] ARM: mediatek: dts: Add uart to Aquaris5 Matthias Brugger
2015-01-05 12:28 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105122849.GF4544@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).