[PATCH 0/2] * ahci_xgene: Bug fixes in APM X-Gene Soc AHCI SATA controller driver.

[PATCH 0/2] * ahci_xgene: Bug fixes in APM X-Gene Soc AHCI SATA controller driver.

[Suman Tripathi]

These patches address the following two issues :

1. Endianess issue with xgene_read_id function.
2. ATAPI device enumeration failure with ATA_CMD_PACKET PIO mode command.

Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org>
---

Suman Tripathi (2):
  ahci_xgene: Fix the endianess issue in APM X-Gene SoC AHCI SATA
    controller driver.
  ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET
    PIO mode command.

 drivers/ata/ahci_xgene.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

--
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] ahci_xgene: Fix the endianess issue in APM X-Gene SoC AHCI SATA controller driver.

[Suman Tripathi]

This patch fixes the big endian mode issue with function
xgene_ahci_read_id.

Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org>
---
 drivers/ata/ahci_xgene.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 0f8538f..0ffd3c9 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -188,7 +188,7 @@ static unsigned int xgene_ahci_read_id(struct ata_device *dev,
 	 *
 	 * Clear reserved bit 8 (DEVSLP bit) as we don't support DEVSLP
 	 */
-	id[ATA_ID_FEATURE_SUPP] &= ~(1 << 8);
+	id[ATA_ID_FEATURE_SUPP] &= cpu_to_le16(~(1 << 8));

 	return 0;
 }
--
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Suman Tripathi]

This patch addresses the issue with ATA_CMD_PACKET pio mode
command for enumeration and device detection with ATAPI devices.It is the
same issue as in patch

www.spinics.net/lists/linux-ide/msg49092.html

Signed-off-by: Suman Tripathi <stripathi-qTEPVZfXA3Y@public.gmane.org>
---
 drivers/ata/ahci_xgene.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
index 0ffd3c9..9730907 100644
--- a/drivers/ata/ahci_xgene.c
+++ b/drivers/ata/ahci_xgene.c
@@ -125,10 +125,11 @@ static int xgene_ahci_restart_engine(struct ata_port *ap)
  * xgene_ahci_qc_issue - Issue commands to the device
  * @qc: Command to issue
  *
- * Due to Hardware errata for IDENTIFY DEVICE command, the controller cannot
- * clear the BSY bit after receiving the PIO setup FIS. This results in the dma
- * state machine goes into the CMFatalErrorUpdate state and locks up. By
- * restarting the dma engine, it removes the controller out of lock up state.
+ * Due to Hardware errata for IDENTIFY DEVICE command and COMMAND PACKET
+ * command of ATAPI protocol set, the controller cannot clear the BSY bit
+ * after receiving the PIO setup FIS. This results in the dma state machine
+ * goes into the CMFatalErrorUpdate state and locks up. By restarting the
+ * dma engine, it removes the controller out of lock up state.
  */
 static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc)
 {
@@ -137,7 +138,8 @@ static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc)
 	struct xgene_ahci_context *ctx = hpriv->plat_data;
 	int rc = 0;

-	if (unlikely(ctx->last_cmd[ap->port_no] == ATA_CMD_ID_ATA))
+	if (unlikely((ctx->last_cmd[ap->port_no] == ATA_CMD_ID_ATA) ||
+	    (ctx->last_cmd[ap->port_no] == ATA_CMD_PACKET)))
 		xgene_ahci_restart_engine(ap);

 	rc = ahci_qc_issue(qc);
--
1.8.2.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Sergei Shtylyov]

Hello.

On 12/16/2014 07:49 PM, Suman Tripathi wrote:

> This patch addresses the issue with ATA_CMD_PACKET pio mode
> command for enumeration and device detection with ATAPI devices.It is the
> same issue as in patch

> www.spinics.net/lists/linux-ide/msg49092.html

> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
>   drivers/ata/ahci_xgene.c | 12 +++++++-----
>   1 file changed, 7 insertions(+), 5 deletions(-)

> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
> index 0ffd3c9..9730907 100644
> --- a/drivers/ata/ahci_xgene.c
> +++ b/drivers/ata/ahci_xgene.c
> @@ -125,10 +125,11 @@ static int xgene_ahci_restart_engine(struct ata_port *ap)
>    * xgene_ahci_qc_issue - Issue commands to the device
>    * @qc: Command to issue
>    *
> - * Due to Hardware errata for IDENTIFY DEVICE command, the controller cannot
> - * clear the BSY bit after receiving the PIO setup FIS. This results in the dma
> - * state machine goes into the CMFatalErrorUpdate state and locks up. By
> - * restarting the dma engine, it removes the controller out of lock up state.
> + * Due to Hardware errata for IDENTIFY DEVICE command and COMMAND PACKET

    Just PACKET.

> + * command of ATAPI protocol set, the controller cannot clear the BSY bit
> + * after receiving the PIO setup FIS. This results in the dma state machine

    DMA.

> + * goes into the CMFatalErrorUpdate state and locks up. By restarting the

    s/goes/going/.

> + * dma engine, it removes the controller out of lock up state.

    DMA again.

>    */
>   static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc)
>   {
[...]

MBR, Sergei

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Sergei Shtylyov]

Hello.

On 12/17/2014 08:21 AM, Suman Tripathi wrote:

>     This patch addresses the issue with ATA_CMD_PACKET pio mode
>     command for enumeration and device detection with ATAPI devices.It is the
>     same issue as in patch

    Ugh, HTML... Please stick to plain text when posting to the 
'vger.kernel.org' mailing lists (HTML mails are supposed to be ignored).

>     www.spinics.net/lists/linux-__ide/msg49092.html
>     <http://www.spinics.net/lists/linux-ide/msg49092.html>
>
>
>     Signed-off-by: Suman Tripathi <stripathi@apm.com <mailto:stripathi@apm.com>>
>     ---
>        drivers/ata/ahci_xgene.c | 12 +++++++-----
>        1 file changed, 7 insertions(+), 5 deletions(-)
>
>
>     diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c
>     index 0ffd3c9..9730907 100644
>     --- a/drivers/ata/ahci_xgene.c
>     +++ b/drivers/ata/ahci_xgene.c
>     @@ -125,10 +125,11 @@ static int xgene_ahci_restart_engine(__struct
>     ata_port *ap)
>         * xgene_ahci_qc_issue - Issue commands to the device
>         * @qc: Command to issue
>         *
>     - * Due to Hardware errata for IDENTIFY DEVICE command, the controller cannot
>     - * clear the BSY bit after receiving the PIO setup FIS. This results in
>     the dma
>     - * state machine goes into the CMFatalErrorUpdate state and locks up. By
>     - * restarting the dma engine, it removes the controller out of lock up state.
>     + * Due to Hardware errata for IDENTIFY DEVICE command and COMMAND PACKET
>
>
>     Just PACKET.
>
>     + * command of ATAPI protocol set, the controller cannot clear the BSY bit
>     + * after receiving the PIO setup FIS. This results in the dma state machine
>
>
>     DMA.
>
>     + * goes into the CMFatalErrorUpdate state and locks up. By restarting the

>     s/goes/going/.

> [suman] : Didn't understand this. Do you mean to change to going ?

    It's a 'sed' command to replace "goes" by "going" IIRC. Yes. Also, 
s/locks/locking/.

> It is already goes there.

> [...]

> Thanks,
> with regards,
> suman

MBR, Sergei

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Sergei Shtylyov]

Hello.

On 12/29/2014 8:35 AM, Suman Tripathi wrote:

>          This patch addresses the issue with ATA_CMD_PACKET pio mode
>          command for enumeration and device detection with ATAPI devices.It is the
>          same issue as in patch


>     Ugh, HTML... Please stick to plain text when posting to the
> 'vger.kernel.org <http://vger.kernel.org/>' mailing lists (HTML mails are
> supposed to be ignored).

>     www.spinics.net/lists/linux-____ide/msg49092.html
>     <http://www.spinics.net/lists/linux-__ide/msg49092.html>
>          <http://www.spinics.net/lists/__linux-ide/msg49092.html
>     <http://www.spinics.net/lists/linux-ide/msg49092.html>>

> This is something strange. I posted it in plain text only. Because when I do
> show original of the patch in gmail, it shows me the plaintext.
> Please help me out to figure the issue. I saw many other patches referred in
> the same way. I am sending the patch through git-send-email  that sends in
> plain text format only,

    The patch was OK, but your replies do use HTML (as well as plain text).

>          Signed-off-by: Suman Tripathi <stripathi@apm.com
>     <mailto:stripathi@apm.com> <mailto:stripathi@apm.com
>     <mailto:stripathi@apm.com>>>

> --
> Thanks,
> with regards,
> Suman Tripathi

MBR, Sergei

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Tejun Heo]

On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote:
> This patch addresses the issue with ATA_CMD_PACKET pio mode
> command for enumeration and device detection with ATAPI devices.It is the
> same issue as in patch
> 
> www.spinics.net/lists/linux-ide/msg49092.html
> 
> Signed-off-by: Suman Tripathi <stripathi@apm.com>

Applied 1-2 to libata/for-3.18-fixes w/ Sergei's suggested edits.

Thanks.

-- 
tejun

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Suman Tripathi]

Hi

On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote:
> This patch addresses the issue with ATA_CMD_PACKET pio mode
> command for enumeration and device detection with ATAPI devices.It is the
> same issue as in patch
>
> www.spinics.net/lists/linux-ide/msg49092.html
>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>

Applied 1-2 to libata/for-3.18-fixes w/ Sergei's suggested edits.

The patch is applied to libata/for-3.19-fixes not libata/for-3.18-fixes ??

On Mon, Jan 5, 2015 at 7:29 PM, Tejun Heo <tj@kernel.org> wrote:
> On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote:
>> This patch addresses the issue with ATA_CMD_PACKET pio mode
>> command for enumeration and device detection with ATAPI devices.It is the
>> same issue as in patch
>>
>> www.spinics.net/lists/linux-ide/msg49092.html
>>
>> Signed-off-by: Suman Tripathi <stripathi@apm.com>
>
> Applied 1-2 to libata/for-3.18-fixes w/ Sergei's suggested edits.
>
> Thanks.
>
> --
> tejun



-- 
Thanks,
with regards,
Suman Tripathi
CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, 
is for the sole use of the intended recipient(s) and contains information
that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries. 
It is to be used solely for the purpose of furthering the parties' business relationship. 
All unauthorized review, use, disclosure or distribution is prohibited. 
If you are not the intended recipient, please contact the sender by reply e-mail 
and destroy all copies of the original message.

Re: [PATCH 2/2] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_PACKET PIO mode command.

[Tejun Heo]

On Tue, Jan 06, 2015 at 01:51:15PM +0530, Suman Tripathi wrote:
> Hi
> 
> On Tue, Dec 16, 2014 at 10:19:35PM +0530, Suman Tripathi wrote:
> > This patch addresses the issue with ATA_CMD_PACKET pio mode
> > command for enumeration and device detection with ATAPI devices.It is the
> > same issue as in patch
> >
> > www.spinics.net/lists/linux-ide/msg49092.html
> >
> > Signed-off-by: Suman Tripathi <stripathi@apm.com>
> 
> Applied 1-2 to libata/for-3.18-fixes w/ Sergei's suggested edits.
> 
> The patch is applied to libata/for-3.19-fixes not libata/for-3.18-fixes ??

Yeap, brainfart.  libata/for-3.19-fixes is the right one.

Thanks.

-- 
tejun