From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Dave Gerlach <d-gerlach@ti.com>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@linaro.org>,
Benoit Cousson <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] remoteproc: wkup_m3: Add wkup_m3 remote proc driver
Date: Mon, 5 Jan 2015 14:48:02 -0800 [thread overview]
Message-ID: <20150105224802.GM4081@atomide.com> (raw)
In-Reply-To: <20150105202032.GQ19336@saruman>
* Felipe Balbi <balbi@ti.com> [150105 12:23]:
> On Mon, Jan 05, 2015 at 02:10:14PM -0600, Dave Gerlach wrote:
> > >> +static int wkup_m3_rpm_suspend(struct device *dev)
> > >> +{
> > >> + return -EBUSY;
> > >> +}
> > >
> > > looks like this is just coping with omap_device bogosity, no ?
> > >
> >
> > Yes, without this omap_device shuts down ther wkup_m3 during suspend, which of
> > course prevents the wkup_m3 from finishing suspend process or waking SoC back
> > up. Haven't found a better solution for the problem than this.
>
> Tony, any better for this ? Do we keep this small hack or find a better
> way ?
Looks OK to me for now, later on we may want to have a flag for
HWMOD_NEVER_IDLE or something similar for wkup_m3_hwmod. But let's
not add more dependencies to this series.
Regards,
Tony
prev parent reply other threads:[~2015-01-05 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 19:51 [PATCH 0/3] remoteproc: Introduce wkup_m3_rproc driver Dave Gerlach
[not found] ` <1420228319-41085-1-git-send-email-d-gerlach-l0cyMroinI0@public.gmane.org>
2015-01-02 19:51 ` [PATCH 1/3] ARM: OMAP2+: Use pdata-quirks for wkup_m3 deassert_hardreset Dave Gerlach
2015-01-02 19:51 ` [PATCH 2/3] Documentation: dt: add ti,am3353-wkup-m3 bindings Dave Gerlach
2015-01-02 19:51 ` [PATCH 3/3] remoteproc: wkup_m3: Add wkup_m3 remote proc driver Dave Gerlach
2015-01-02 20:04 ` Felipe Balbi
2015-01-05 20:10 ` Dave Gerlach
2015-01-05 20:20 ` Felipe Balbi
2015-01-05 22:48 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105224802.GM4081@atomide.com \
--to=tony@atomide.com \
--cc=arnd@arndb.de \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=d-gerlach@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).