From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 3/3] remoteproc: wkup_m3: Add wkup_m3 remote proc driver Date: Mon, 5 Jan 2015 14:48:02 -0800 Message-ID: <20150105224802.GM4081@atomide.com> References: <1420228319-41085-1-git-send-email-d-gerlach@ti.com> <1420228319-41085-4-git-send-email-d-gerlach@ti.com> <20150102200424.GD4920@saruman> <54AAEFA6.3080603@ti.com> <20150105202032.GQ19336@saruman> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20150105202032.GQ19336@saruman> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Felipe Balbi Cc: Ohad Ben-Cohen , devicetree@vger.kernel.org, Arnd Bergmann , Dave Gerlach , linux-kernel@vger.kernel.org, Kevin Hilman , Benoit Cousson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org * Felipe Balbi [150105 12:23]: > On Mon, Jan 05, 2015 at 02:10:14PM -0600, Dave Gerlach wrote: > > >> +static int wkup_m3_rpm_suspend(struct device *dev) > > >> +{ > > >> + return -EBUSY; > > >> +} > > > > > > looks like this is just coping with omap_device bogosity, no ? > > > > > > > Yes, without this omap_device shuts down ther wkup_m3 during suspend, which of > > course prevents the wkup_m3 from finishing suspend process or waking SoC back > > up. Haven't found a better solution for the problem than this. > > Tony, any better for this ? Do we keep this small hack or find a better > way ? Looks OK to me for now, later on we may want to have a flag for HWMOD_NEVER_IDLE or something similar for wkup_m3_hwmod. But let's not add more dependencies to this series. Regards, Tony