devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "Heiko Stübner" <heiko@sntech.de>, "Andy Yan" <andy.yan@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	David Airlie <airlied@linux.ie>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Yakir Yang <ykk@rock-chips.com>,
	devel@driverdev.osuosl.org, Pawel Moll <pawel.moll@arm.com>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Grant Likely <grant.likely@linaro.org>,
	Dave Airlie <airlied@redhat.com>,
	Xu Jianqun <jay.xu@rock-chips.com>,
	"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Inki Dae <inki.dae@samsung.com>, Rob Herring <robh+dt@kernel.org>,
	Sean Paul <seanpaul@chromium.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"mark.yao@rock-chips.com" <mark.yao@rock-chips.com>,
	fabio.estevam@freescale.com, Josh Boyer <jwboyer@redhat.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.o>
Subject: Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support
Date: Tue, 6 Jan 2015 13:51:29 +0000	[thread overview]
Message-ID: <20150106135129.GG12302@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <6479148.dVz0vTNYfK@phil>

On Thu, Dec 11, 2014 at 12:24:15PM +0100, Heiko Stübner wrote:
> Past practices suggest that having the dw in the name is a sane solution too, 
> like in dw_mmc-foo (mmc/host), dwmac-foo (net/ethernet/stmicro/stmmac).
> 
> And personally I'd keep to this already established naming scheme ... i.e. not 
> hiding the dw heritage.
> 
> And also it looks like other involved parties like Philipp and Russell seemed 
> to be ok with the naming through the revisions till now.

I don't have much of a preference when it comes to this.  I was disappointed
that the original imx-hdmi driver did not use "dw" in its filename, as the
documentation clearly stated in several places that it was a designware
part, and as we all know, they're a company which sells IP, so their
designs are going to crop up in different places.

So I welcome this patch set - and I've also tested it on a SolidRun
Hummingboard i2ex along with all my CEC and audio patches, where it
seems to be fine.  So for the set:

Tested-by: Russell King <rmk+kernel@arm.linux.org.uk>

Apart from the two minor items I've pointed out in separate replies:

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-01-06 13:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05  6:22 [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Andy Yan
2014-12-05  6:23 ` [PATCH v18 01/12] drm: imx: imx-hdmi: make checkpatch happy Andy Yan
2014-12-05  6:24 ` [PATCH v18 02/12] drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter Andy Yan
2014-12-05  6:25 ` [PATCH v18 03/12] drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode Andy Yan
2015-01-06 11:52   ` [PATCH v18.1 " Heiko Stübner
2015-01-06 13:42     ` Russell King - ARM Linux
2014-12-05  6:25 ` [PATCH v18 04/12] drm: imx: imx-hdmi: split phy configuration to platform driver Andy Yan
     [not found]   ` <1417760750-17047-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-01-06 13:44     ` Russell King - ARM Linux
2014-12-05  6:26 ` [PATCH v18 05/12] drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi Andy Yan
2014-12-05  6:27 ` [PATCH v18 06/12] dt-bindings: add document for dw_hdmi Andy Yan
2014-12-05 13:54   ` Philipp Zabel
2014-12-08  6:10     ` Andy Yan
2014-12-05  6:28 ` [PATCH v18 07/12] drm: bridge/dw_hdmi: add support for multi-byte register width access Andy Yan
2014-12-05  6:30 ` [PATCH v18 08/12] drm: bridge/dw_hdmi: add mode_valid support Andy Yan
2014-12-05  6:31 ` [PATCH v18 09/12] drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done Andy Yan
2014-12-05  6:31 ` [PATCH v18 10/12] drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare Andy Yan
2014-12-05  6:33 ` [PATCH v18 11/12] dt-bindings: Add documentation for rockchip dw hdmi Andy Yan
2014-12-05  6:34 ` [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Andy Yan
     [not found]   ` <1417761259-17429-1-git-send-email-andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-12-11  4:36     ` Daniel Kurtz
2014-12-11 11:24       ` Heiko Stübner
2015-01-06 13:51         ` Russell King - ARM Linux [this message]
2015-01-07  7:48     ` Andy Yan
2014-12-05 13:55 ` [PATCH v18 0/12] dw-hdmi: convert imx hdmi to bridge/dw_hdmi Philipp Zabel
2014-12-05 16:31   ` Andy Yan
2015-01-06 11:49     ` Heiko Stübner
2015-01-06 15:27       ` Philipp Zabel
2015-01-07  2:39 ` Liu Ying
2015-01-07  7:17   ` Andy Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150106135129.GG12302@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Zubair.Kakakhel@imgtec.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=andy.yan@rock-chips.com \
    --cc=arnd@arndb.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@freescale.com \
    --cc=grant.likely@linaro.org \
    --cc=gregkh@linuxfoundation.o \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=inki.dae@samsung.com \
    --cc=jay.xu@rock-chips.com \
    --cc=jwboyer@redhat.com \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mark.yao@rock-chips.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=ykk@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).