From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v18 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Date: Tue, 6 Jan 2015 13:51:29 +0000 Message-ID: <20150106135129.GG12302@n2100.arm.linux.org.uk> References: <1417760564-16858-1-git-send-email-andy.yan@rock-chips.com> <1417761259-17429-1-git-send-email-andy.yan@rock-chips.com> <6479148.dVz0vTNYfK@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <6479148.dVz0vTNYfK@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan Cc: Mark Rutland , David Airlie , Daniel Kurtz , Yakir Yang , devel@driverdev.osuosl.org, Pawel Moll , "open list:ARM/Rockchip SoC..." , Grant Likely , Dave Airlie , Xu Jianqun , "open list:OPEN FIRMWARE AND..." , Zubair Lutfullah Kakakhel , Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , dri-devel , "mark.yao@rock-chips.com" , fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman List-Id: devicetree@vger.kernel.org On Thu, Dec 11, 2014 at 12:24:15PM +0100, Heiko St=FCbner wrote: > Past practices suggest that having the dw in the name is a sane solution = too, = > like in dw_mmc-foo (mmc/host), dwmac-foo (net/ethernet/stmicro/stmmac). > = > And personally I'd keep to this already established naming scheme ... i.e= . not = > hiding the dw heritage. > = > And also it looks like other involved parties like Philipp and Russell se= emed = > to be ok with the naming through the revisions till now. I don't have much of a preference when it comes to this. I was disappointed that the original imx-hdmi driver did not use "dw" in its filename, as the documentation clearly stated in several places that it was a designware part, and as we all know, they're a company which sells IP, so their designs are going to crop up in different places. So I welcome this patch set - and I've also tested it on a SolidRun Hummingboard i2ex along with all my CEC and audio patches, where it seems to be fine. So for the set: Tested-by: Russell King Apart from the two minor items I've pointed out in separate replies: Acked-by: Russell King Thanks. -- = FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up according to speedtest.net.