From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Sylwester Nawrocki <s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
drake-6IF/jdPJHihWk0Htik3J/w@public.gmane.org,
sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 02/16] ASoC: samsung: i2s: samsung_i2s_get_driver_data() cleanup
Date: Tue, 6 Jan 2015 18:14:02 +0000 [thread overview]
Message-ID: <20150106181402.GP2634@sirena.org.uk> (raw)
In-Reply-To: <1418997336-17777-3-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 344 bytes --]
On Fri, Dec 19, 2014 at 02:55:22PM +0100, Sylwester Nawrocki wrote:
> Tidy up the samsung_i2s_get_driver_data() function by using
> IS_ENABLE() instead of #ifdef and add missing braces for
> the 'else' part. Also ensure we are not dereferencing NULL
> 'match' pointer.
This doesn't apply against current code, can you please check and
resend?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-06 18:14 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 13:55 [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 01/16] ASoC: samsung: i2s: Remove unused gpios field from struct i2s Sylwester Nawrocki
2015-01-06 18:13 ` Mark Brown
2014-12-19 13:55 ` [PATCH v2 02/16] ASoC: samsung: i2s: samsung_i2s_get_driver_data() cleanup Sylwester Nawrocki
[not found] ` <1418997336-17777-3-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-06 18:14 ` Mark Brown [this message]
2015-01-14 11:52 ` Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 03/16] ASoC: samsung: i2s: Add return value checks in probe() Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 04/16] ASoC: samsung: i2s: Request memory region in driver probe() Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 05/16] ASoC: samsung: i2s: Move clk_get() to platform " Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 06/16] ASoC: samsung: i2s: Move clk enable to the " Sylwester Nawrocki
2015-01-06 18:06 ` Mark Brown
2015-01-14 11:56 ` Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 07/16] ASoC: samsung: i2s: Add get_other_dai helper function Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 08/16] ASoC: samsung: i2s: Remove an unneeded goto usage Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 09/16] ASoC: samsung: i2s: Add spinlock in place of local_irq_* calls Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 10/16] ASoC: samsung: i2s: Protect more registers with a spinlock Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 11/16] ASoC: samsung: odroidx2: Handle I2S CDCLK clock conditionally Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 12/16] ASoC: samsung: i2s: Add clk provider DT binding documentation Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 13/16] ASoC: samsung: i2s: Add clock provider for the I2S internal clocks Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 14/16] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 15/16] ARM: dts: Switch Odroid X2/U2 to simple-audio-card Sylwester Nawrocki
2014-12-19 13:55 ` [PATCH v2 16/16] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs Sylwester Nawrocki
2015-01-06 18:15 ` Mark Brown
2015-01-14 11:57 ` Sylwester Nawrocki
2015-01-06 18:17 ` [PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks Mark Brown
2015-01-24 1:53 ` Tobias Jakobi
[not found] ` <54C2FB25.4030501-hi6Y0CQ0nG0@public.gmane.org>
2015-01-27 10:59 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150106181402.GP2634@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=drake-6IF/jdPJHihWk0Htik3J/w@public.gmane.org \
--cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=padma.v-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
--cc=sbkim73-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).