From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Parrot Subject: Re: [Patch v5 2/2] gpio: Document GPIO hogging mechanism Date: Mon, 12 Jan 2015 10:39:02 -0600 Message-ID: <20150112163902.GE5834@ti.com> References: <1419019671-25377-1-git-send-email-bparrot@ti.com> <1419019671-25377-3-git-send-email-bparrot@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org To: Linus Walleij , Alexandre Courbot Cc: "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Maxime Ripard , Jiri Prchal , Pantelis Antoniou List-Id: devicetree@vger.kernel.org Linus Walleij wrote on Mon [2015-Jan-12 11:20:14 +0100]: > On Fri, Dec 19, 2014 at 9:07 PM, Benoit Parrot wrote: > > > Add GPIO hogging documentation to gpio.txt > > > > Signed-off-by: Benoit Parrot > > Reviewed-by: Alexandre Courbot > > This is starting to look good ... > > > + line_b { > > + gpio-hog; > > + gpios = <6 0>; > > + state = "output-low"; > > I don't like the state string. > > Instead have boolean properties for all states. > > line_b { > gpio-hog; > gpios = <6 0>; > output-low; > line-name = "foo-bar-gpio"; > } > > Then use of_property_read_bool() in the code to check which > state is to be selected intially. You can check that no mutually > exclusive state are selected, I don't like that an arbitrary string > select the state like that, if we do it that way an enumerator would > be better, I prefer bools. I am sorry but that is how it was originally in the first patch. Alexandre's review comment suggested this method in [1] and [2] (below). Alexandre, any comments? [1] http://marc.info/?l=linux-gpio&m=141456662426151&w=2 [2] http://marc.info/?l=linux-gpio&m=141715982424744&w=2 > > Yours, > Linus Walleij > -- > To unsubscribe from this list: send the line "unsubscribe linux-gpio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html