From: Guenter Roeck <linux@roeck-us.net>
To: Jim Davis <jim.epost@gmail.com>
Cc: linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
jdelvare@suse.de, Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
lm-sensors@lm-sensors.org,
devicetree <devicetree@vger.kernel.org>,
Nishanth Menon <nm@ti.com>,
Eduardo Valentin <edubezval@gmail.com>
Subject: Re: randconfig build error with next-20150112, in drivers/hwmon/gpio-fan.c
Date: Mon, 12 Jan 2015 09:25:37 -0800 [thread overview]
Message-ID: <20150112172537.GA19868@roeck-us.net> (raw)
In-Reply-To: <CA+r1Zhh4EXQ_0pYZfL4jB=F8unP7+jzp7LVL2RRL+urU3srj3A@mail.gmail.com>
On Mon, Jan 12, 2015 at 09:53:05AM -0700, Jim Davis wrote:
> Building with the attached random configuration file,
>
> drivers/built-in.o: In function `gpio_fan_remove':
> gpio-fan.c:(.text+0x6efea): undefined reference to
> `thermal_cooling_device_unregister'
> drivers/built-in.o: In function `gpio_fan_probe':
> gpio-fan.c:(.text+0x6f376): undefined reference to
> `thermal_cooling_device_register'
> make: *** [vmlinux] Error 1
Hi Jim,
thanks for the note.
Hmm .. turns out those functions don't define dummies if CONFIG_THERMAL
is not configured. How annoying.
Nishant, please fix your gpio-fan patch. I am going to drop it for now.
Please keep in mind that there is a secondary dependency: The thermal
code can be built as module. In that case, the gpio-fan driver must
either also be built as module, or its thermal registration must be
disabled.
Guenter
prev parent reply other threads:[~2015-01-12 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 16:53 randconfig build error with next-20150112, in drivers/hwmon/gpio-fan.c Jim Davis
2015-01-12 17:25 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112172537.GA19868@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=grant.likely@linaro.org \
--cc=jdelvare@suse.de \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).