Devicetree
 help / color / mirror / Atom feed
From: Inha Song <ideal.song@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, sbkim73@samsung.com,
	linux-kernel@vger.kernel.org, lgirdwood@gmail.com, tiwai@suse.de,
	robh+dt@kernel.org, kgene@kernel.org, s.nawrocki@samsung.com,
	galak@codeaurora.org, grant.likely@linaro.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings
Date: Tue, 13 Jan 2015 10:27:34 +0900	[thread overview]
Message-ID: <20150113102734.7a3aa77a@songinha-Samsung-DeskTop-System> (raw)
In-Reply-To: <20150105152918.GT11764@sirena.org.uk>

Hi Mark,

Thank you for your feedback and sorry for late response.

I think, I should remove clock settings in machine driver.
If the clock settings are necessary, I will add "assigned-clocks" nodes
in trats2 sound DT like odroid board.

Best Regards,
Inha Song.

> On Mon, Jan 05, 2015 at 08:25:16PM +0900, Inha Song wrote:
> 
> > + - clocks : Reference to the codec master clock
> > + - clock-names : The clock should be named "mclk"
> 
> This should be done in the CODEC driver, not in the machine driver - the
> CODEC always needs the clock, it's not something specific to this
> machine.  Even if we decide that for Linux the best thing to do is to
> manage the clock in the machine driver it should be described in the DT
> as being attached to the CODEC.

  reply	other threads:[~2015-01-13  1:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 11:25 [alsa-devel] [PATCH 0/3] Sound support for Exynos4412 Trats2 board Inha Song
2015-01-05 11:25 ` [alsa-devel] [PATCH 1/3] ASoC: samsung: Add machine driver for Trats2 Inha Song
     [not found]   ` <1420457117-11030-2-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-05 11:48     ` Lars-Peter Clausen
2015-01-05 12:40       ` Inha Song
2015-01-05 11:25 ` [alsa-devel] [PATCH 2/3] ASoC: samsung: Document Trats2 audio subsystem bindings Inha Song
2015-01-05 15:29   ` Mark Brown
2015-01-13  1:27     ` Inha Song [this message]
2015-01-05 11:25 ` [alsa-devel] [PATCH 3/3] ARM: dts: Add sound nodes for exynos4412-trats2 Inha Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113102734.7a3aa77a@songinha-Samsung-DeskTop-System \
    --to=ideal.song@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kgene@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sbkim73@samsung.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox