From: Mark Brown <broonie@kernel.org>
To: Ken Wilson <ken.wilson@opengear.com>
Cc: thomas.petazzoni@free-electrons.com, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
ezequiel.garcia@free-electrons.com, gerg@uclinux.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCHv2 2/2] spi: orion: Add multiple chip select support to spi-orion
Date: Wed, 14 Jan 2015 20:06:26 +0000 [thread overview]
Message-ID: <20150114200626.GN3043@sirena.org.uk> (raw)
In-Reply-To: <1421032440-15335-3-git-send-email-ken.wilson@opengear.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Mon, Jan 12, 2015 at 01:14:00PM +1000, Ken Wilson wrote:
> +- num-cs : The total number of chip selects used by this platform.
> + If unset, this defaults to 1.
So, this is intended to be the number of hardware chip selects that can
be configured but the first commit mentioned GPIOs as an option too so
we should at least say that this is specifically the controller
supported ones. However...
> +#define ORION_SPI_CS_MASK 0x1C
> +#define ORION_SPI_CS_SHIFT 2
> +#define ORION_SPI_CS(cs) ((cs << ORION_SPI_CS_SHIFT) & \
> + ORION_SPI_CS_MASK)
...given that we have a fixed bitfield here which we know and doesn't
appear to depend on configuration do we even need this to be
configurable - given that we're going to need an explicit node for any
slave can't we just accept any sane chip select for a slave without
extending the binding?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-14 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 3:13 [PATCHv2 0/2] spi: orion: Add multiple chip select support to spi-orion Ken Wilson
2015-01-12 3:13 ` [PATCHv2 1/2] spi: orion: Change spi-orion to use transfer_one() semantics for SPI transfers Ken Wilson
[not found] ` <1421032440-15335-2-git-send-email-ken.wilson-xg7Pnmy8KxlWk0Htik3J/w@public.gmane.org>
2015-01-14 17:22 ` Mark Brown
2015-01-12 3:14 ` [PATCHv2 2/2] spi: orion: Add multiple chip select support to spi-orion Ken Wilson
2015-01-14 20:06 ` Mark Brown [this message]
[not found] ` <20150114200626.GN3043-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-01-15 1:07 ` Ken Wilson
2015-01-15 11:22 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114200626.GN3043@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=galak@codeaurora.org \
--cc=gerg@uclinux.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ken.wilson@opengear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).