From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v2 1/5] rtc: armada38x: Add the device tree binding documentation Date: Wed, 14 Jan 2015 20:22:52 +0100 Message-ID: <20150114202252.457d328e@free-electrons.com> References: <1421257155-3379-1-git-send-email-gregory.clement@free-electrons.com> <1421257155-3379-2-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1421257155-3379-2-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Gregory CLEMENT Cc: Alessandro Zummo , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Arnaud Ebalard , Ezequiel Garcia , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Maxime Ripard , Boris BREZILLON , Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Dear Gregory CLEMENT, On Wed, 14 Jan 2015 18:39:11 +0100, Gregory CLEMENT wrote: > +Required properties: > +- compatible : Should be "marvell,armada-380-rtc" > +- reg: physical base address of the controller and length of memory > + mapped region, associated to the reg-name "rtc". The other entry is > + related to the interrupt control from the SoC, associated to the > + reg-name "soc-interrupt". soc-interrupt or... > +- reg-names: names of the mapped memory regions listed in regs > + property in the same order: "rtc" and "soc-int". soc-int ? > +rtc@a3800 { > + compatible = "marvell,armada-380-rtc"; > + reg = <0xa3800 0x20>, <0x184a0 0x0c>; Any reason to use <0x184A0 0xC> instead of <0x184A8 0x4> ? According to the datasheet, there is only this 184A8 register for RTC stuff. Thanks, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html