From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v5 2/5] Documentation: DT: Add bindings for Spreadtrum SoC Platform Date: Fri, 16 Jan 2015 14:11:09 +0000 Message-ID: <20150116141109.GC22569@leverpostej> References: <1421402411-3479-1-git-send-email-chunyan.zhang@spreadtrum.com> <1421402411-3479-3-git-send-email-chunyan.zhang@spreadtrum.com> <20150116102135.GC21809@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lyra Zhang Cc: Chunyan Zhang , "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" , "arnd-r2nGTMty4D4@public.gmane.org" , "gnomes-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org" , "broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Pawel Moll , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , Will Deacon , Catalin Marinas , "jslaby-AlSwsSmVLrQ@public.gmane.org" , "jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org" , "heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org" , "florian.vaussard-p8DiymsW2f8@public.gmane.org" , "andrew-g2DYL2Zd6BY@public.gmane.org" , "rrichter-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org" , "hytszk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org" , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , antonynpavlov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Jan 16, 2015 at 12:53:16PM +0000, Lyra Zhang wrote: > Hi, Mark > > >> + > >> +Required properties: > >> +- compatible: must be "sprd,sc9836-uart" > >> +- reg: offset and length of the register set for the device > >> +- interrupts: exactly one interrupt specifier > >> +- clocks: phandles to input clocks. > > > > The order and relevance of each should be specified. If you have > > multiple clocks I would strongly recommend you use clock-names to > > distinguish them. > > > > Thank you for the recommendation. > but, since we haven't made the clock driver ready, for this initial > commit, we just let 4 UARTs share a single fixed 26 MHz clock source. > we'll do like you've recommended when we will submit the clock driver > in the future. I'm on about the clock input lines on the UART instance, not the providers they come from. Is there only a single clock input line on each UART? Perhaps multiple input lines which are currently fed by the same clock? Thanks, Mark.