* [PATCH] mfd: omap-usb-host: Remove some unused functions
@ 2015-01-04 0:11 Rickard Strandqvist
2015-01-20 13:43 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-04 0:11 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones
Cc: Rickard Strandqvist, Grant Likely, Rob Herring, linux-kernel,
devicetree
Removes some functions that are not used anywhere:
usbhs_readb() usbhs_writeb()
This was partially found by using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/mfd/omap-usb-host.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
index 83dab2f..6b0f305 100644
--- a/drivers/mfd/omap-usb-host.c
+++ b/drivers/mfd/omap-usb-host.c
@@ -129,16 +129,6 @@ static inline u32 usbhs_read(void __iomem *base, u32 reg)
return readl_relaxed(base + reg);
}
-static inline void usbhs_writeb(void __iomem *base, u8 reg, u8 val)
-{
- writeb_relaxed(val, base + reg);
-}
-
-static inline u8 usbhs_readb(void __iomem *base, u8 reg)
-{
- return readb_relaxed(base + reg);
-}
-
/*-------------------------------------------------------------------------*/
/**
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: omap-usb-host: Remove some unused functions
2015-01-04 0:11 [PATCH] mfd: omap-usb-host: Remove some unused functions Rickard Strandqvist
@ 2015-01-20 13:43 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-01-20 13:43 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Samuel Ortiz, Grant Likely, Rob Herring, linux-kernel, devicetree
On Sun, 04 Jan 2015, Rickard Strandqvist wrote:
> Removes some functions that are not used anywhere:
> usbhs_readb() usbhs_writeb()
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/mfd/omap-usb-host.c | 10 ----------
> 1 file changed, 10 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 83dab2f..6b0f305 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -129,16 +129,6 @@ static inline u32 usbhs_read(void __iomem *base, u32 reg)
> return readl_relaxed(base + reg);
> }
>
> -static inline void usbhs_writeb(void __iomem *base, u8 reg, u8 val)
> -{
> - writeb_relaxed(val, base + reg);
> -}
> -
> -static inline u8 usbhs_readb(void __iomem *base, u8 reg)
> -{
> - return readb_relaxed(base + reg);
> -}
> -
> /*-------------------------------------------------------------------------*/
>
> /**
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-20 13:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-04 0:11 [PATCH] mfd: omap-usb-host: Remove some unused functions Rickard Strandqvist
2015-01-20 13:43 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).