From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v4 2/6] mfd: MT6397: Add support for PMIC MT6397 MFD Date: Tue, 20 Jan 2015 15:33:01 +0000 Message-ID: <20150120153301.GZ13701@x1> References: <1419577768-12037-1-git-send-email-flora.fu@mediatek.com> <1419577768-12037-3-git-send-email-flora.fu@mediatek.com> <20150120144309.GT13701@x1> <20150120150512.GA12209@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20150120150512.GA12209@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Sascha Hauer Cc: Flora Fu , Mark Rutland , Menghui Lin , Russell King , Samuel Ortiz , arm@kernel.org, Grant Likely , Yingjoe Chen , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , HenryC Chen , Rob Herring , Matthias Brugger , Eddie Huang , linux-arm-kernel@lists.infradead.org, Dongdong Cheng , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, Arnd Bergmann , Sascha Hauer , Kumar Gala , Olof Johansson , Chen Zhong List-Id: devicetree@vger.kernel.org On Tue, 20 Jan 2015, Sascha Hauer wrote: > Hi Lee, >=20 > On Tue, Jan 20, 2015 at 02:43:09PM +0000, Lee Jones wrote: > > On Fri, 26 Dec 2014, Flora Fu wrote: > >=20 > > > Add core files for MT6397 MFD driver. > > >=20 > > > Signed-off-by: Flora Fu > > > --- > > > drivers/mfd/Kconfig | 10 + > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/mt6397-core.c | 94 +++++++++ > > > include/linux/mfd/mt6397/core.h | 23 +++ > > > include/linux/mfd/mt6397/registers.h | 362 +++++++++++++++++++++= ++++++++++++++ > > > 5 files changed, 490 insertions(+) > > > create mode 100644 drivers/mfd/mt6397-core.c > > > create mode 100644 include/linux/mfd/mt6397/core.h > > > create mode 100644 include/linux/mfd/mt6397/registers.h > >=20 > > Looks okay. > >=20 > > I assume there are dependancies on this patch. What are they? > >=20 > > How would you like this set to be handled? >=20 > This patch is outdated, I sent an updated series today (you are on Cc= ). Okay, thanks. > There are no compile time dependencies to the PMIC wrapper, but witho= ut > it the mfd part is pretty useless. I prefer to keep the series togeth= er > and merge it through arm-soc, but I would be fine with merging it > through mfd aswell. Yes, everyone feels the same about their cross-subsystem patch-sets. ;) If there are build-time dependencies I am always happy to take sets in via MFD and send out pull-requests to other subsystem Maintainers; however, if there are only run-time dependencies I prefer to save everyone the hassle and have them go in via their own subsystems. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog