[alsa-devel] [PATCH v2 RESEND 0/2] mfd: arizona: Add support for OUTn_MONO register control

[alsa-devel] [PATCH v2 RESEND 0/2] mfd: arizona: Add support for OUTn_MONO register control

[Inha Song]

This patch series add support for OUTn_MONO register control using platform data.
Each output signal can be configurated as a mono differential output.
The mono differential configuration is selected using the OUTn_MONO registers.

Changes in v2:
 - fix coding style issue
 - use ">=" instead of "==" in condition check

Inha Song (2):
  mfd: arizona: Add support for OUTn_MONO register control
  mfd: arizona: Update DT binding to support OUTn_MONO init_data

 Documentation/devicetree/bindings/mfd/arizona.txt |  7 +++++++
 drivers/mfd/arizona-core.c                        | 10 ++++++++++
 2 files changed, 17 insertions(+)

-- 
2.0.0.390.gcb682f8

[alsa-devel] [PATCH v2 RESEND 1/2] mfd: arizona: Add support for OUTn_MONO register control

[Inha Song]

Some boards need to set the OUTn_MONO register to configurates
the output signal path as a mono differential output. This
wlf,out-mono property is optional. If present, values must be
specified less than or equal to the number of output signals.
If values less than the number of output signals, elements
that has not been specified are set to 0 by default.

Example:
 - wlf,out-mono = <1 0 1>; /* set OUT1,OUT3 to mono differential */

Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/mfd/arizona-core.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index bce7c07..cc2927d 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -561,6 +561,16 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
 		count++;
 	}
 
+	count = 0;
+	of_property_for_each_u32(arizona->dev->of_node,
+				 "wlf,out-mono", prop, cur, val) {
+		if (count >= ARRAY_SIZE(arizona->pdata.out_mono))
+			break;
+
+		arizona->pdata.out_mono[count] = !!val;
+		count++;
+	}
+
 	return 0;
 }
 
-- 
2.0.0.390.gcb682f8

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 RESEND 1/2] mfd: arizona: Add support for OUTn_MONO register control

[Charles Keepax]

On Fri, Jan 02, 2015 at 05:03:48PM +0900, Inha Song wrote:
> Some boards need to set the OUTn_MONO register to configurates
> the output signal path as a mono differential output. This
> wlf,out-mono property is optional. If present, values must be
> specified less than or equal to the number of output signals.
> If values less than the number of output signals, elements
> that has not been specified are set to 0 by default.
> 
> Example:
>  - wlf,out-mono = <1 0 1>; /* set OUT1,OUT3 to mono differential */
> 
> Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---

Acked-by: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 RESEND 1/2] mfd: arizona: Add support for OUTn_MONO register control

[Lee Jones]

DT Ack (for this and the doc) required.

> Some boards need to set the OUTn_MONO register to configurates
> the output signal path as a mono differential output. This
> wlf,out-mono property is optional. If present, values must be
> specified less than or equal to the number of output signals.
> If values less than the number of output signals, elements
> that has not been specified are set to 0 by default.
> 
> Example:
>  - wlf,out-mono = <1 0 1>; /* set OUT1,OUT3 to mono differential */
> 
> Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  drivers/mfd/arizona-core.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index bce7c07..cc2927d 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -561,6 +561,16 @@ static int arizona_of_get_core_pdata(struct arizona *arizona)
>  		count++;
>  	}
>  
> +	count = 0;
> +	of_property_for_each_u32(arizona->dev->of_node,
> +				 "wlf,out-mono", prop, cur, val) {
> +		if (count >= ARRAY_SIZE(arizona->pdata.out_mono))
> +			break;
> +
> +		arizona->pdata.out_mono[count] = !!val;
> +		count++;
> +	}
> +
>  	return 0;
>  }
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 RESEND 1/2] mfd: arizona: Add support for OUTn_MONO register control

[Charles Keepax]

On Fri, Jan 02, 2015 at 05:03:48PM +0900, Inha Song wrote:
> Some boards need to set the OUTn_MONO register to configurates
> the output signal path as a mono differential output. This
> wlf,out-mono property is optional. If present, values must be
> specified less than or equal to the number of output signals.
> If values less than the number of output signals, elements
> that has not been specified are set to 0 by default.
> 
> Example:
>  - wlf,out-mono = <1 0 1>; /* set OUT1,OUT3 to mono differential */
> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---

Apologies, I must have missed this in the December rush here.

Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>

Thanks,
Charles

[alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Inha Song]

This patch update DT binding to support OUTn_MONO init_data. Each
output signal can be configurated as a mono differential output.
The mono differential configuration is selected using the OUTn_MONO
registers.

Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
index 7bd1273..cf11d42 100644
--- a/Documentation/devicetree/bindings/mfd/arizona.txt
+++ b/Documentation/devicetree/bindings/mfd/arizona.txt
@@ -49,6 +49,13 @@ Optional properties:
     input singals. If values less than the number of input signals, elements
     that has not been specifed are set to 0 by default.
 
+  - wlf,out-mono : A list of OUTn_MONO register values, where n is the number
+    of output signals. Valid values are 0 (Disabled) and 1 (Enabled). If absent,
+    OUTn_MONO registers set to 0 by default. If present, values must be specified
+    less than or equal to the number of output signals. If values less than the
+    number of input signals, elements that has not been specified are set to 0
+    by default.
+
   - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
     they are being externally supplied. As covered in
     Documentation/devicetree/bindings/regulator/regulator.txt
-- 
2.0.0.390.gcb682f8

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Charles Keepax]

On Fri, Jan 02, 2015 at 05:03:49PM +0900, Inha Song wrote:
> This patch update DT binding to support OUTn_MONO init_data. Each
> output signal can be configurated as a mono differential output.
> The mono differential configuration is selected using the OUTn_MONO
> registers.
> 
> Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---

Acked-by: Charles Keepax <ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Lee Jones]

On Fri, 02 Jan 2015, Inha Song wrote:

> This patch update DT binding to support OUTn_MONO init_data. Each
> output signal can be configurated as a mono differential output.
> The mono differential configuration is selected using the OUTn_MONO
> registers.

This requires a DT Ack and an entry in the example.

> Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/arizona.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 7bd1273..cf11d42 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -49,6 +49,13 @@ Optional properties:
>      input singals. If values less than the number of input signals, elements
>      that has not been specifed are set to 0 by default.
>  
> +  - wlf,out-mono : A list of OUTn_MONO register values, where n is the number
> +    of output signals. Valid values are 0 (Disabled) and 1 (Enabled). If absent,
> +    OUTn_MONO registers set to 0 by default. If present, values must be specified
> +    less than or equal to the number of output signals. If values less than the
> +    number of input signals, elements that has not been specified are set to 0
> +    by default.
> +
>    - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
>      they are being externally supplied. As covered in
>      Documentation/devicetree/bindings/regulator/regulator.txt

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 657 bytes --]

On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> On Fri, 02 Jan 2015, Inha Song wrote:

> > This patch update DT binding to support OUTn_MONO init_data. Each
> > output signal can be configurated as a mono differential output.
> > The mono differential configuration is selected using the OUTn_MONO
> > registers.

> This requires a DT Ack and an entry in the example.

The DT maintainers have said they're OK with maintainers just merging
things if they're comfortable with it (see the bindings specific
submitting-patches.txt) and given their workload and general resulting
responsiveness it's going to make it difficult go get anything done.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Lee Jones]

On Tue, 20 Jan 2015, Mark Brown wrote:

> On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> > On Fri, 02 Jan 2015, Inha Song wrote:
> 
> > > This patch update DT binding to support OUTn_MONO init_data. Each
> > > output signal can be configurated as a mono differential output.
> > > The mono differential configuration is selected using the OUTn_MONO
> > > registers.
> 
> > This requires a DT Ack and an entry in the example.
> 
> The DT maintainers have said they're OK with maintainers just merging
> things if they're comfortable with it (see the bindings specific
> submitting-patches.txt) and given their workload and general resulting
> responsiveness it's going to make it difficult go get anything done.

I only tend to poke the DT guys when I am unsure of something in the
binding.  In this case it was a doubt whether we should be encoding
register values inside a property like this.

I would also be happy to take it with your Ack if you're happy with
it?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Charles Keepax]

On Tue, Jan 20, 2015 at 04:02:48PM +0000, Lee Jones wrote:
> On Tue, 20 Jan 2015, Mark Brown wrote:
> 
> > On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> > > On Fri, 02 Jan 2015, Inha Song wrote:
> > 
> > > > This patch update DT binding to support OUTn_MONO init_data. Each
> > > > output signal can be configurated as a mono differential output.
> > > > The mono differential configuration is selected using the OUTn_MONO
> > > > registers.
> > 
> > > This requires a DT Ack and an entry in the example.
> > 
> > The DT maintainers have said they're OK with maintainers just merging
> > things if they're comfortable with it (see the bindings specific
> > submitting-patches.txt) and given their workload and general resulting
> > responsiveness it's going to make it difficult go get anything done.
> 
> I only tend to poke the DT guys when I am unsure of something in the
> binding.  In this case it was a doubt whether we should be encoding
> register values inside a property like this.
> 
> I would also be happy to take it with your Ack if you're happy with
> it?

In this case really it is a boolean indicating if the
corresponding output is mono or not. It is handled thusly in the
code:

		if (arizona->pdata.out_mono[i])
			val = ARIZONA_OUT1_MONO;
		else
			val = 0;

Perhaps some further wording tweaks on the Documentation patch
would be appropriate, but certainly I am happy enough with the
binding.

Thanks,
Charles

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Lee Jones]

On Tue, 20 Jan 2015, Charles Keepax wrote:

> On Tue, Jan 20, 2015 at 04:02:48PM +0000, Lee Jones wrote:
> > On Tue, 20 Jan 2015, Mark Brown wrote:
> > 
> > > On Tue, Jan 20, 2015 at 12:20:05PM +0000, Lee Jones wrote:
> > > > On Fri, 02 Jan 2015, Inha Song wrote:
> > > 
> > > > > This patch update DT binding to support OUTn_MONO init_data. Each
> > > > > output signal can be configurated as a mono differential output.
> > > > > The mono differential configuration is selected using the OUTn_MONO
> > > > > registers.
> > > 
> > > > This requires a DT Ack and an entry in the example.
> > > 
> > > The DT maintainers have said they're OK with maintainers just merging
> > > things if they're comfortable with it (see the bindings specific
> > > submitting-patches.txt) and given their workload and general resulting
> > > responsiveness it's going to make it difficult go get anything done.
> > 
> > I only tend to poke the DT guys when I am unsure of something in the
> > binding.  In this case it was a doubt whether we should be encoding
> > register values inside a property like this.
> > 
> > I would also be happy to take it with your Ack if you're happy with
> > it?
> 
> In this case really it is a boolean indicating if the
> corresponding output is mono or not. It is handled thusly in the
> code:
> 
> 		if (arizona->pdata.out_mono[i])
> 			val = ARIZONA_OUT1_MONO;
> 		else
> 			val = 0;
> 
> Perhaps some further wording tweaks on the Documentation patch
> would be appropriate, but certainly I am happy enough with the
> binding.

Very well.  As you and Mark seem happy with the approach I will be
more lenient on the next submission.  An example and some working
tweaks would improve chances of acceptance further still.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [alsa-devel] [PATCH v2 RESEND 2/2] mfd: arizona: Update DT binding to support OUTn_MONO init_data

[Charles Keepax]

On Fri, Jan 02, 2015 at 05:03:49PM +0900, Inha Song wrote:
> This patch update DT binding to support OUTn_MONO init_data. Each
> output signal can be configurated as a mono differential output.
> The mono differential configuration is selected using the OUTn_MONO
> registers.
> 
> Signed-off-by: Inha Song <ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---

Agree with Lee an example probably would be nice. But otherwise
this looks fine.

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html