devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: balbi@ti.com, tony@atomide.com, myungjoo.ham@samsung.com,
	cw00.choi@samsung.com, george.cherian@ti.com, nsekhar@ti.com,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: dra72-evm: Add extcon nodes for USB
Date: Tue, 20 Jan 2015 13:02:18 -0600	[thread overview]
Message-ID: <20150120190218.GF15169@saruman> (raw)
In-Reply-To: <1421689942-10201-5-git-send-email-rogerq@ti.com>

[-- Attachment #1: Type: text/plain, Size: 2177 bytes --]

On Mon, Jan 19, 2015 at 07:52:21PM +0200, Roger Quadros wrote:
> On this EVM, the USB cable state has to be determined via the
> ID pin tied to a GPIO line. We use the gpio-usb-extcon driver
> to read the ID pin and the extcon framework to forward
> the USB cable state information to the USB driver so the
> controller can be configured in the right mode (host/peripheral).
> 
> Gets USB peripheral mode to work on this EVM.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Felipe Balbi <balbi@ti.com>

> ---
>  arch/arm/boot/dts/dra72-evm.dts | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra72-evm.dts b/arch/arm/boot/dts/dra72-evm.dts
> index 89085d0..d93a98f 100644
> --- a/arch/arm/boot/dts/dra72-evm.dts
> +++ b/arch/arm/boot/dts/dra72-evm.dts
> @@ -8,6 +8,7 @@
>  /dts-v1/;
>  
>  #include "dra72x.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>  
>  / {
>  	model = "TI DRA722";
> @@ -24,6 +25,16 @@
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
>  	};
> +
> +	extcon_usb1: extcon_usb1 {
> +		compatible = "linux,extcon-usb";
> +		id-gpio = <&pcf_gpio_21 1 GPIO_ACTIVE_HIGH>;
> +	};
> +
> +	extcon_usb2: extcon_usb2 {
> +		compatible = "linux,extcon-usb";
> +		id-gpio = <&pcf_gpio_21 2 GPIO_ACTIVE_HIGH>;
> +	};
>  };
>  
>  &dra7_pmx_core {
> @@ -243,6 +254,18 @@
>  			ti,palmas-long-press-seconds = <6>;
>  		};
>  	};
> +
> +	pcf_gpio_21: gpio@21 {
> +		compatible = "ti,pcf8575";
> +		reg = <0x21>;
> +		lines-initial-states = <0x1408>;
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		interrupt-parent = <&gpio6>;
> +		interrupts = <11 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +	};
>  };
>  
>  &uart1 {
> @@ -345,6 +368,14 @@
>  	phy-supply = <&ldo4_reg>;
>  };
>  
> +&omap_dwc3_1 {
> +	extcon = <&extcon_usb1>;
> +};
> +
> +&omap_dwc3_2 {
> +	extcon = <&extcon_usb2>;
> +};
> +
>  &usb1 {
>  	dr_mode = "peripheral";
>  	pinctrl-names = "default";
> -- 
> 2.1.0
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-01-20 19:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 17:52 [PATCH 0/5] extcon: usb: Introduce USB GPIO extcon driver. Fix DRA7 USB Roger Quadros
     [not found] ` <1421689942-10201-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-01-19 17:52   ` [PATCH 1/5] extcon: gpio-usb: Introduce gpio usb extcon driver Roger Quadros
     [not found]     ` <1421689942-10201-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2015-01-20 19:00       ` Felipe Balbi
2015-01-21  5:28       ` Chanwoo Choi
     [not found]         ` <54BF3918.2000300-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-01-22 13:27           ` Roger Quadros
2015-01-19 17:52 ` [PATCH 2/5] usb: extcon: Fix USB-Host cable name Roger Quadros
2015-01-20 19:01   ` Felipe Balbi
2015-01-19 17:52 ` [PATCH 3/5] ARM: dts: dra7-evm: Add extcon nodes for USB Roger Quadros
2015-01-20 19:02   ` Felipe Balbi
2015-01-19 17:52 ` [PATCH 4/5] ARM: dts: dra72-evm: " Roger Quadros
2015-01-20 19:02   ` Felipe Balbi [this message]
2015-01-19 17:52 ` [PATCH 5/5] ARM: omap2plus_defconfig: Enable PCF857X and EXTCON_GPIO_USB Roger Quadros
2015-01-19 18:45   ` Tony Lindgren
2015-01-19 19:38     ` Tony Lindgren
2015-01-20  9:26       ` Roger Quadros
2015-01-20 19:02 ` [PATCH 0/5] extcon: usb: Introduce USB GPIO extcon driver. Fix DRA7 USB Felipe Balbi
2015-01-22 13:32   ` Roger Quadros
2015-01-22 14:57     ` Roger Quadros
2015-01-22 20:29       ` Felipe Balbi
     [not found]         ` <20150122202907.GC22288-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-01-23  7:26           ` Roger Quadros
2015-01-23 16:19             ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150120190218.GF15169@saruman \
    --to=balbi@ti.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=george.cherian@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=nsekhar@ti.com \
    --cc=rogerq@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).