devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] power: ab8500_fg.c:  Remove unused function
@ 2015-01-01 17:04 Rickard Strandqvist
  2015-01-02  9:32 ` Arnd Bergmann
       [not found] ` <1420131892-31486-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
  0 siblings, 2 replies; 3+ messages in thread
From: Rickard Strandqvist @ 2015-01-01 17:04 UTC (permalink / raw)
  To: Sebastian Reichel, Dmitry Eremin-Solenikov
  Cc: Rickard Strandqvist, David Woodhouse, Grant Likely, Rob Herring,
	linux-pm, linux-kernel, devicetree

Remove the function ab8500_fg_reinit() that is not used anywhere.

This was partially found by using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/power/ab8500_fg.c            |   14 --------------
 include/linux/mfd/abx500/ab8500-bm.h |    1 -
 2 files changed, 15 deletions(-)

diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
index 217da4b..72c82ab 100644
--- a/drivers/power/ab8500_fg.c
+++ b/drivers/power/ab8500_fg.c
@@ -2434,20 +2434,6 @@ static void ab8500_fg_reinit_work(struct work_struct *work)
 	}
 }
 
-/**
- * ab8500_fg_reinit() - forces FG algorithm to reinitialize with current values
- *
- * This function can be used to force the FG algorithm to recalculate a new
- * voltage based battery capacity.
- */
-void ab8500_fg_reinit(void)
-{
-	struct ab8500_fg *di = ab8500_fg_get();
-	/* User won't be notified if a null pointer returned. */
-	if (di != NULL)
-		queue_delayed_work(di->fg_wq, &di->fg_reinit_work, 0);
-}
-
 /* Exposure to the sysfs interface */
 
 struct ab8500_fg_sysfs_entry {
diff --git a/include/linux/mfd/abx500/ab8500-bm.h b/include/linux/mfd/abx500/ab8500-bm.h
index cc892a8..12a5b39 100644
--- a/include/linux/mfd/abx500/ab8500-bm.h
+++ b/include/linux/mfd/abx500/ab8500-bm.h
@@ -461,7 +461,6 @@ struct ab8500_fg;
 #ifdef CONFIG_AB8500_BM
 extern struct abx500_bm_data ab8500_bm_data;
 
-void ab8500_fg_reinit(void);
 void ab8500_charger_usb_state_changed(u8 bm_usb_state, u16 mA);
 struct ab8500_btemp *ab8500_btemp_get(void);
 int ab8500_btemp_get_batctrl_temp(struct ab8500_btemp *btemp);
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] power: ab8500_fg.c:  Remove unused function
  2015-01-01 17:04 [PATCH] power: ab8500_fg.c: Remove unused function Rickard Strandqvist
@ 2015-01-02  9:32 ` Arnd Bergmann
       [not found] ` <1420131892-31486-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
  1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-01-02  9:32 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Sebastian Reichel, Dmitry Eremin-Solenikov, David Woodhouse,
	Grant Likely, Rob Herring, linux-pm, linux-kernel, devicetree

On Thursday 01 January 2015 18:04:52 Rickard Strandqvist wrote:
> Remove the function ab8500_fg_reinit() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Acked-by: Arnd Bergmann <arnd@arndb.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] power: ab8500_fg.c:  Remove unused function
       [not found] ` <1420131892-31486-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
@ 2015-01-21 13:32   ` Sebastian Reichel
  0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2015-01-21 13:32 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Dmitry Eremin-Solenikov, David Woodhouse, Grant Likely,
	Rob Herring, linux-pm-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi,

On Thu, Jan 01, 2015 at 06:04:52PM +0100, Rickard Strandqvist wrote:
> Remove the function ab8500_fg_reinit() that is not used anywhere.
> 
> This was partially found by using a static code analysis program called cppcheck.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Thanks, applied with Acked-By from Arnd.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-01-21 13:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-01 17:04 [PATCH] power: ab8500_fg.c: Remove unused function Rickard Strandqvist
2015-01-02  9:32 ` Arnd Bergmann
     [not found] ` <1420131892-31486-1-git-send-email-rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
2015-01-21 13:32   ` Sebastian Reichel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).