Re: [PATCH RFC 2/2] ARM64: psci: implement system suspend using PSCI v0.2 CPU SUSPEND

[Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>]

On Thu, Jan 22, 2015 at 06:18:12AM +0000, Leo Yan wrote:

[...]

> How about unify the power states passing for cpu idle and suspend?
> 
> below is a example for dts which place all power state into psci
> entry, so that idle-states and system suspend both can reference
> the power state.
> 
> psci {
> 	compatible = "arm,psci-0.2";
> 	method = "smc";
> 
>         power_state {
>                 CPU_POWER_OFF: cpu_power_off {
>                         state = <0x00010000>;
>                 };
> 
>                 CLUSTER_POWER_OFF: cluster_power_off {
>                         state = <0x01010000>;
>                 };
> 
>                 SOC_SUSPEND: soc_suspend {
>                         state = <0x01010001>;
>                 };
>         };
> };

I do not see why this would help. We would end up with phandles to
the nodes above to get the parameter from idle-states, to me it
looks like churn honestly, I do not see where the improvement is.

Lorenzo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html