[PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Lee Jones]

CLK_S_ICN_REG_0 hasn't existed for a while now.  This was renamed
over a few commits, then finally removed in commit 5aa02b9 (ARM:
STi: DT: STiH415: Remove unused CLK_S_ICN_REG_0 fixed clock).

Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
 Documentation/devicetree/bindings/i2c/i2c-st.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-st.txt b/Documentation/devicetree/bindings/i2c/i2c-st.txt
index 437e0db..4c26fda 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-st.txt
+++ b/Documentation/devicetree/bindings/i2c/i2c-st.txt
@@ -31,7 +31,7 @@ i2c0: i2c@fed40000 {
 	compatible	= "st,comms-ssc4-i2c";
 	reg		= <0xfed40000 0x110>;
 	interrupts	=  <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
-	clocks		= <&CLK_S_ICN_REG_0>;
+	clocks		= <&clk_s_a0_ls CLK_ICN_REG>;
 	clock-names	= "ssc";
 	clock-frequency = <400000>;
 	pinctrl-names	= "default";
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [STLinux Kernel] [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Maxime Coquelin]

Hi Lee,

On 08/28/2014 04:02 PM, Lee Jones wrote:
> CLK_S_ICN_REG_0 hasn't existed for a while now.  This was renamed
> over a few commits, then finally removed in commit 5aa02b9 (ARM:
> STi: DT: STiH415: Remove unused CLK_S_ICN_REG_0 fixed clock).
>
> Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Maybe it will be part of my next pull-requests, but in case it is not, 
you can add my:
Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>

Thanks,
Maxime
> ---
>   Documentation/devicetree/bindings/i2c/i2c-st.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-st.txt b/Documentation/devicetree/bindings/i2c/i2c-st.txt
> index 437e0db..4c26fda 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-st.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-st.txt
> @@ -31,7 +31,7 @@ i2c0: i2c@fed40000 {
>   	compatible	= "st,comms-ssc4-i2c";
>   	reg		= <0xfed40000 0x110>;
>   	interrupts	=  <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> -	clocks		= <&CLK_S_ICN_REG_0>;
> +	clocks		= <&clk_s_a0_ls CLK_ICN_REG>;
>   	clock-names	= "ssc";
>   	clock-frequency = <400000>;
>   	pinctrl-names	= "default";
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [STLinux Kernel] [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Lee Jones]

On Thu, 28 Aug 2014, Maxime Coquelin wrote:
> On 08/28/2014 04:02 PM, Lee Jones wrote:
> >CLK_S_ICN_REG_0 hasn't existed for a while now.  This was renamed
> >over a few commits, then finally removed in commit 5aa02b9 (ARM:
> >STi: DT: STiH415: Remove unused CLK_S_ICN_REG_0 fixed clock).
> >
> >Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Maybe it will be part of my next pull-requests, but in case it is
> not, you can add my:
> Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Still nothing from the big man.

Can you just take this please Maxime?

> >---
> >  Documentation/devicetree/bindings/i2c/i2c-st.txt | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/Documentation/devicetree/bindings/i2c/i2c-st.txt b/Documentation/devicetree/bindings/i2c/i2c-st.txt
> >index 437e0db..4c26fda 100644
> >--- a/Documentation/devicetree/bindings/i2c/i2c-st.txt
> >+++ b/Documentation/devicetree/bindings/i2c/i2c-st.txt
> >@@ -31,7 +31,7 @@ i2c0: i2c@fed40000 {
> >  	compatible	= "st,comms-ssc4-i2c";
> >  	reg		= <0xfed40000 0x110>;
> >  	interrupts	=  <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> >-	clocks		= <&CLK_S_ICN_REG_0>;
> >+	clocks		= <&clk_s_a0_ls CLK_ICN_REG>;
> >  	clock-names	= "ssc";
> >  	clock-frequency = <400000>;
> >  	pinctrl-names	= "default";
> >

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [STLinux Kernel] [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Peter Griffin]

Hi,

On Thu, 28 Aug 2014, Lee Jones wrote:

> CLK_S_ICN_REG_0 hasn't existed for a while now.  This was renamed
> over a few commits, then finally removed in commit 5aa02b9 (ARM:
> STi: DT: STiH415: Remove unused CLK_S_ICN_REG_0 fixed clock).
> 
> Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Acked-by: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

regards,

Peter.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Lee Jones]

Wolfram,

This patch has been on the list since forever.

I have Acks from the driver author, so I'm going to take this through
the MFD tree.  If you perk up later and decide to take it though the
I2C tree instead, let me know and I'll remove it from MFD.

> CLK_S_ICN_REG_0 hasn't existed for a while now.  This was renamed
> over a few commits, then finally removed in commit 5aa02b9 (ARM:
> STi: DT: STiH415: Remove unused CLK_S_ICN_REG_0 fixed clock).
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-st.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-st.txt b/Documentation/devicetree/bindings/i2c/i2c-st.txt
> index 437e0db..4c26fda 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-st.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-st.txt
> @@ -31,7 +31,7 @@ i2c0: i2c@fed40000 {
>  	compatible	= "st,comms-ssc4-i2c";
>  	reg		= <0xfed40000 0x110>;
>  	interrupts	=  <GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>;
> -	clocks		= <&CLK_S_ICN_REG_0>;
> +	clocks		= <&clk_s_a0_ls CLK_ICN_REG>;
>  	clock-names	= "ssc";
>  	clock-frequency = <400000>;
>  	pinctrl-names	= "default";

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 660 bytes --]

On Thu, Jan 22, 2015 at 12:18:19PM +0000, Lee Jones wrote:
> Wolfram,
> 
> This patch has been on the list since forever.

For reasons :)

a) It was not CCed to the i2c list, so it doesn't show up in patchwork
which does the patch tracking for me.

b) I was always under the impression that Maxime is going to take it?
He said so.

> I have Acks from the driver author, so I'm going to take this through
> the MFD tree.  If you perk up later and decide to take it though the
> I2C tree instead, let me know and I'll remove it from MFD.

Well, I2C makes more sense than MFD, so I'll pick it up right now.
ST-tree would have also been fine.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

On Thu, Aug 28, 2014 at 03:02:03PM +0100, Lee Jones wrote:
> CLK_S_ICN_REG_0 hasn't existed for a while now.  This was renamed
> over a few commits, then finally removed in commit 5aa02b9 (ARM:
> STi: DT: STiH415: Remove unused CLK_S_ICN_REG_0 fixed clock).
> 
> Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Applied to for-current, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/1] i2c: i2c-st: Rename clock reference to something that exists

[Lee Jones]

On Thu, 22 Jan 2015, Wolfram Sang wrote:

> On Thu, Jan 22, 2015 at 12:18:19PM +0000, Lee Jones wrote:
> > Wolfram,
> > 
> > This patch has been on the list since forever.
> 
> For reasons :)
> 
> a) It was not CCed to the i2c list, so it doesn't show up in patchwork
> which does the patch tracking for me.
> 
> b) I was always under the impression that Maxime is going to take it?
> He said so.
> 
> > I have Acks from the driver author, so I'm going to take this through
> > the MFD tree.  If you perk up later and decide to take it though the
> > I2C tree instead, let me know and I'll remove it from MFD.
> 
> Well, I2C makes more sense than MFD, so I'll pick it up right now.
> ST-tree would have also been fine.

Works for me.  Thanks dude.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog