From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 RESEND 1/8] dt: bindings: Supply shared ST IRQ defines Date: Fri, 23 Jan 2015 16:39:38 +0000 Message-ID: <20150123163938.GC11745@x1> References: <1421920133-7914-1-git-send-email-lee.jones@linaro.org> <1421920133-7914-2-git-send-email-lee.jones@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Thomas Gleixner Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, jason@lakedaemon.net, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, 23 Jan 2015, Thomas Gleixner wrote: > On Thu, 22 Jan 2015, Lee Jones wrote: >=20 > > These defines are used to allow values used for configuration to be > > easily human readable and will lessen the chance of logical mistake= s. > >=20 > > Signed-off-by: Lee Jones > > --- > > include/dt-bindings/interrupt-controller/irq-st.h | 30 +++++++++++= ++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 include/dt-bindings/interrupt-controller/irq-st= =2Eh > >=20 > > diff --git a/include/dt-bindings/interrupt-controller/irq-st.h b/in= clude/dt-bindings/interrupt-controller/irq-st.h > > new file mode 100644 > > index 0000000..4c59ace > > --- /dev/null > > +++ b/include/dt-bindings/interrupt-controller/irq-st.h > > @@ -0,0 +1,30 @@ > > +/* > > + * include/linux/irqchip/irq-st.h >=20 > Copy & Paste? >=20 > Can we please stop adding these pointless filenames all over the > place? They are useless and wrong in a lot of cases. Less of a copy and paste and more and a `mv` without fixing up the file names. I guess they are silly, but they are rife, so someone must think they're a good idea. :) for file in `find drivers -name *.c`; do head $file | grep "\.c$"; do= ne > Aside of that, this needs an ack from the DT folks. I think you'll be lucky. I haven't seen a DT review for some time now. Perhaps, as it's you, this might be different. ;) --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog