From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v9 3/5] regulators: axp20x: Use "clock-frequency" property for dcdc work frequency
Date: Tue, 27 Jan 2015 12:14:24 +0000 [thread overview]
Message-ID: <20150127121424.GS21293@sirena.org.uk> (raw)
In-Reply-To: <1421941147-9682-4-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Thu, Jan 22, 2015 at 11:39:05PM +0800, Chen-Yu Tsai wrote:
> Since the dcdc regulator work frequency is a property of the regulators
> DT sub-tree, there is no issue of naming collisions, so we can use the
> standard "clock-frequency" binding for this.
>
> The driver sets a reasonable default value (same as the datasheet), and
> only 1 dts has the old binding, with the default value.
I don't see any benefit from this change - not only is this an
incompatible change (which may affect out of tree users as well as in
tree users) but it's not really doing anything with the clock API which
I'd expect to be happening for a clock API property. What's the goal
here?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-27 12:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 15:39 [PATCH v9 0/5] mfd: axp20x: add support for AXP202 and AXP209 Chen-Yu Tsai
2015-01-22 15:39 ` [PATCH v9 1/5] dt-bindings: add vendor-prefix for X-Powers Chen-Yu Tsai
2015-01-22 15:39 ` [PATCH v9 2/5] mfd: AXP20x: Add bindings documentation Chen-Yu Tsai
2015-01-22 16:02 ` Lee Jones
2015-01-31 16:49 ` Chen-Yu Tsai
2015-02-02 8:53 ` Lee Jones
2015-02-10 7:34 ` Chen-Yu Tsai
2015-01-22 15:39 ` [PATCH v9 3/5] regulators: axp20x: Use "clock-frequency" property for dcdc work frequency Chen-Yu Tsai
[not found] ` <1421941147-9682-4-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>
2015-01-27 12:14 ` Mark Brown [this message]
2015-01-22 15:39 ` [PATCH v9 4/5] regulators: axp20x: Change dcdc-workmode DT property to boolean flag Chen-Yu Tsai
2015-01-27 12:27 ` Mark Brown
2015-01-22 15:39 ` [PATCH v9 5/5] ARM: sunxi: dts: axp209: Use clock-frequency for DC-DC work frequency Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150127121424.GS21293@sirena.org.uk \
--to=broonie-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).