From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2 2/4] gpio: add parameter to allow the use named gpios Date: Fri, 30 Jan 2015 14:16:00 -0800 Message-ID: <20150130221600.GB11695@dtor-ws> References: <1421876028-22799-1-git-send-email-o.schinagl@ultimaker.com> <1421876028-22799-3-git-send-email-o.schinagl@ultimaker.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-leds-owner@vger.kernel.org To: Bryan Wu Cc: Linus Walleij , Olliver Schinagl , Alexandre Courbot , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Richard Purdie , Olliver Schinagl , Robin Gong , Mika Westerberg , Aaron Lu , Grant Likely , Jingoo Han , Alexander Shiyan , Wolfram Sang , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , Linux Input lin List-Id: devicetree@vger.kernel.org On Fri, Jan 30, 2015 at 11:12:53AM -0800, Bryan Wu wrote: > On Fri, Jan 30, 2015 at 5:46 AM, Linus Walleij wrote: > > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > > wrote: > > > >> From: Olliver Schinagl > >> > >> The gpio binding document says that new code should always use named > >> gpios. Patch 40b73183 added support to parse a list of gpios from child > >> nodes, but does not make it possible to use named gpios. This patch adds > >> the con_id property and implements it is done in gpiolib.c, where the > >> old-style of using unnamed gpios still works. > >> > >> Signed-off-by: Olliver Schinagl > >> --- > >> drivers/gpio/devres.c | 18 +++++++++++++++++- > >> drivers/input/keyboard/gpio_keys_polled.c | 2 +- > >> drivers/leds/leds-gpio.c | 2 +- > >> include/linux/gpio/consumer.h | 1 + > > > > Alexandre: does this match your vision of how it should work, i.e. ACK? > > > > Bryan/Dmitry: can you ACK the oneliners in your subsystems? > > Sure, please take my Ack > Acked-by: Bryan Wu Mine as well: Acked-by: Dmitry Torokhov Thanks. -- Dmitry