From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v3 01/10] clk: sunxi: Move USB clocks to separate file Date: Sun, 1 Feb 2015 14:53:33 +0100 Message-ID: <20150201135332.GB4827@lukather> References: <1422388455-25923-1-git-send-email-wens@csie.org> <1422388455-25923-2-git-send-email-wens@csie.org> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oLBj+sq0vYjzfsbl" Return-path: Content-Disposition: inline In-Reply-To: <1422388455-25923-2-git-send-email-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Mike Turquette , Emilio Lopez , Rob Herring , Grant Likely , Kishon Vijay Abraham I , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org --oLBj+sq0vYjzfsbl Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Wed, Jan 28, 2015 at 03:54:06AM +0800, Chen-Yu Tsai wrote: > The USB clocks originally shared code with the gates clocks, but had > additional reset controllers. Move these to a separate file. This will > allow us to add new support for slightly different USB clocks, such as > on the A80, without affecting gates clocks, and also facilitate the > migration of gates clocks to a generic solution. > > This also cleans up the USB clocks code slightly, such as adding > newlines, getting rid of the unused clkdev call, using a simple > u32 instead of BITMAP for the clock masks, using BIT() macro to > declare the clock bitmasks, and using of_io_request_and_map() to > get the I/O address. > > Signed-off-by: Chen-Yu Tsai Applied, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --oLBj+sq0vYjzfsbl--