Re: [PATCH] ARM: shmobile: silk: initial device tree

[Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>]

Hi Sergei,

On Sat, Jan 31, 2015 at 09:27:05PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 1/31/2015 7:21 AM, Simon Horman wrote:
> 
> >>Add the initial device tree for the R8A7794 SoC based SILK low cost board.
> >>SCIF2 serial port support is included, so that the serial console can work.
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
> 
> >>---
> >>This patch is against the 'renesas-devel-20150129-v3.19-rc6' tag of Simon
> >>Horman's 'renesas.git' repo.
> 
> >>  arch/arm/boot/dts/Makefile         |    1
> >>  arch/arm/boot/dts/r8a7794-silk.dts |   41 +++++++++++++++++++++++++++++++++++++
> >>  2 files changed, 42 insertions(+)
> 
> [...]
> >>Index: renesas/arch/arm/boot/dts/r8a7794-silk.dts
> >>===================================================================
> >>--- /dev/null
> >>+++ renesas/arch/arm/boot/dts/r8a7794-silk.dts
> >>@@ -0,0 +1,41 @@
> >>+/*
> >>+ * Device Tree Source for the SILK board
> >>+ *
> >>+ * Copyright (C) 2014 Renesas Electronics Corporation
> >>+ * Copyright (C) 2014-2015 Renesas Solutions Corp.
> >>+ * Copyright (C) 2014-2015 Cogent Embedded, Inc.
> >>+ *
> >>+ * This file is licensed under the terms of the GNU General Public License
> >>+ * version 2.  This program is licensed "as is" without any warranty of any
> >>+ * kind, whether express or implied.
> >>+ */
> >>+
> >>+/dts-v1/;
> >>+#include "r8a7794.dtsi"
> >>+
> >>+/ {
> >>+	model = "SILK";
> >>+	compatible = "renesas,silk", "renesas,r8a7794";
> >>+
> >>+	aliases {
> >>+		serial0 = &scif2;
> >>+	};
> >>+
> >>+	chosen {
> >>+		bootargs = "console=ttySC0,38400 ignore_loglevel";
> 
> >Please remove console= for consistency with other boards
> >based on Renesas SoCs.
> 
>    I can't, there will be no console at all.

Its not clear to me why that should be the case when you also have:

		stdout-path = &scif2;

Is this a baud issue? If so is it possible to set uboot to 115200 bps?
This would be consistent with the way other boards are handled in mainline.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html