devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Suman Tripathi <stripathi@apm.com>
Cc: olof@lixom.net, arnd@arndb.de, linux-scsi@vger.kernel.org,
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, mlangsdo@redhat.com,
	jcm@redhat.com, patches@apm.com
Subject: Re: [PATCH v3] ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.
Date: Tue, 3 Feb 2015 11:18:09 -0500	[thread overview]
Message-ID: <20150203161809.GG19463@htj.dyndns.org> (raw)
In-Reply-To: <1422900439-5541-2-git-send-email-stripathi@apm.com>

On Mon, Feb 02, 2015 at 11:37:19PM +0530, Suman Tripathi wrote:
> This patch addresses the issue with ATA_CMD_SMART pio mode
> command for enumeration and device detection with ATA devices.
> The X-Gene AHCI controller has an errata in which it cannot clear
> the BSY bit after the PIO setup FIS. The dma state machine enters
> CMFatalErrorUpdate state and locks up. It is the same issue as
> in the commit 2a0bdff6b958d1b2523d2754b6cd5e0ea4053016 (ahci-xgene:

The right format is 2a0bdff6b958 ("ahci-xgene: fix the dma state
machine lockup for the IDENTIFY DEVICE PIO mode command").

> fix the dma state machine lockup for the IDENTIFY DEVICE PIO mode
> command).
> 
> For example :  without this patch it results in READ DMA command failure
> as shown below :
> 
>  [  126.700072] ata2.00: exception Emask 0x0 SAct 0x0
> 		SErr 0x0 action 0x6 frozen
>  [  126.707089] ata2.00: failed command: READ DMA
>  [  126.711426] ata2.00: cmd c8/00:08:00:55:57/00:00:00:00:00/e1 tag 1
>                 dma 4096 in
>  [  126.711426]  res 40/00:ff:00:00:00/00:00:00:00:00/40 Emask
> 		0x4 (timeout)
>  [  126.725956] ata2.00: status: { DRDY }
> 
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> Reported-by:   Mark Langsdorf <mlangsdo@redhat.com>

Applied to libata/for-3.19-fixes.

Thanks.

-- 
tejun

      parent reply	other threads:[~2015-02-03 16:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-02 18:07 [PATCH v3] Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command Suman Tripathi
2015-02-02 18:07 ` [PATCH v3] ahci_xgene: " Suman Tripathi
     [not found]   ` <1422900439-5541-2-git-send-email-stripathi-qTEPVZfXA3Y@public.gmane.org>
2015-02-02 19:12     ` Sergei Shtylyov
     [not found]       ` <CAOHikRBMPbyS0q6814+Xkez7ToBwrC7Yzp4sy=NMmPDg-5wCBA@mail.gmail.com>
2015-02-02 19:44         ` Sergei Shtylyov
2015-02-02 19:48           ` Suman Tripathi
2015-02-03 16:12             ` Suman Tripathi
2015-02-03 16:18   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150203161809.GG19463@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=jcm@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mlangsdo@redhat.com \
    --cc=olof@lixom.net \
    --cc=patches@apm.com \
    --cc=stripathi@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).