From: Mark Rutland <mark.rutland@arm.com>
To: Addy Ke <addy.ke@rock-chips.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"tgih.jun@samsung.com" <tgih.jun@samsung.com>,
"jh80.chung@samsung.com" <jh80.chung@samsung.com>,
"chris@printf.net" <chris@printf.net>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"dinguyen@altera.com" <dinguyen@altera.com>,
"heiko@sntech.de" <heiko@sntech.de>,
"olof@lixom.net" <olof@lixom.net>,
"dianders@chromium.org" <dianders@chromium.org>,
"sonnyrao@chromium.org" <sonnyrao@chromium.org>,
"amstan@chromium.org" <amstan@chromium.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mmc@vge
Subject: Re: [PATCH] mmc: core: add runtime-resume caps to support resume at runtime_resume
Date: Thu, 5 Feb 2015 11:27:01 +0000 [thread overview]
Message-ID: <20150205112701.GD11344@leverpostej> (raw)
In-Reply-To: <1423134419-23109-1-git-send-email-addy.ke@rock-chips.com>
On Thu, Feb 05, 2015 at 11:06:59AM +0000, Addy Ke wrote:
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
> ---
> Documentation/devicetree/bindings/mmc/mmc.txt | 11 +++++++++++
> drivers/mmc/core/host.c | 2 ++
> 2 files changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt b/Documentation/devicetree/bindings/mmc/mmc.txt
> index 438899e..303b448 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -40,9 +40,20 @@ Optional properties:
> - mmc-hs200-1_2v: eMMC HS200 mode(1.2V I/O) is supported
> - mmc-hs400-1_8v: eMMC HS400 mode(1.8V I/O) is supported
> - mmc-hs400-1_2v: eMMC HS400 mode(1.2V I/O) is supported
> +- runtime-resume: resume at runtime_resume is supported
This reads like description of Linux internals (runtime_resume), which
shouldn't be in the DT.
What does this mean at the HW level? I'm sure we can find a better name
for this, or another way of describing this.
> - dsr: Value the card's (optional) Driver Stage Register (DSR) should be
> programmed with. Valid range: [0 .. 0xffff].
>
> +Card power and reset control:
> +The following properties can be specified for cases where the MMC
> +peripheral needs additional reset, regulator and clock lines. It is for
> +example common for WiFi/BT adapters to have these separate from the main
> +MMC bus:
> + - card-reset-gpios: Specify GPIOs for card reset (reset active low)
> + - card-external-vcc-supply: Regulator to drive (independent) card VCC
> + - clock with name "card_ext_clock": External clock provided to the card
Are these proeprties placed on the MMC controller node, or a sub-node
representing the card/slot?
Thanks,
Mark.
next prev parent reply other threads:[~2015-02-05 11:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 11:06 [PATCH] mmc: core: add runtime-resume caps to support resume at runtime_resume Addy Ke
2015-02-05 11:20 ` Heiko Stübner
2015-02-05 11:27 ` Mark Rutland [this message]
2015-02-05 11:44 ` addy.ke
2015-02-05 11:50 ` [PATCH v2] " Addy Ke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150205112701.GD11344@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=addy.ke@rock-chips.com \
--cc=amstan@chromium.org \
--cc=chris@printf.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dinguyen@altera.com \
--cc=galak@codeaurora.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vge \
--cc=olof@lixom.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sonnyrao@chromium.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).