From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v5 2/7] mailbox: arm_mhu: add driver for ARM MHU controller Date: Thu, 5 Feb 2015 12:08:29 +0000 Message-ID: <20150205120829.GO8656@n2100.arm.linux.org.uk> References: <1422955310-6542-1-git-send-email-Vincent.Yang@tw.fujitsu.com> <3540319.u6RL7AO77m@wuerfel> <2790199.44Rvt91EcZ@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jassi Brar Cc: Arnd Bergmann , Vincent Yang , Kumar Gala , Rob Herring , Devicetree List , Vincent Yang , Andy Green , Sudeep Holla , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Mark Rutland , =?utf-8?B?UGF3ZcWC?= Moll , Olof Johansson , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , Patch Tracking , arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Tetsuya Nuriya List-Id: devicetree@vger.kernel.org On Thu, Feb 05, 2015 at 05:32:39PM +0530, Jassi Brar wrote: > On Feb 5, 2015 5:13 PM, "Arnd Bergmann" wrote: > > > > > > > > I know typedef's are frowned upon, but how bad is the following option? > > > typedef void* mbox_data_info > > > int mbox_send_message(struct mbox_chan *chan, mbox_data_info > data); > > > > I don't see how that would help. > > > If it's abuse because the argument is a void*... What if we called it > mbox_data_info? To say platforms are free to pass data as a pointer or a > value :) Using a typedef really doesn't change anything. If you read the kernel coding style, you'll realise that typedefs are a reason to reject patches - especially to use them in the way you are proposing. Try the solution I suggested (which I notice was seemingly totally ignored.) -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html