From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 5 Feb 2015 19:44:58 +0800 From: "addy.ke@rock-chips.com" Subject: Re: Re: [PATCH] mmc: core: add runtime-resume caps to support resume at runtime_resume References: <1423134419-23109-1-git-send-email-addy.ke@rock-chips.com>, <20150205112701.GD11344@leverpostej> Mime-Version: 1.0 Message-ID: <2015020519445667643729@rock-chips.com> Content-Type: multipart/alternative; boundary="----=_001_NextPart467682210521_=----" To: Mark Rutland Cc: "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "rdunlap@infradead.org" , "tgih.jun@samsung.com" , "jh80.chung@samsung.com" , "chris@printf.net" , "ulf.hansson@linaro.org" , "dinguyen@altera.com" , =?utf-8?B?SGVpa28gU3TDvGJuZXI=?= , olof , dianders , "sonnyrao@chromium.org" , "amstan@chromium.org" , "devicetree@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , =?utf-8?B?5pa56ZWH56aP?= , =?utf-8?B?ImVkZGllKOiUoeaeqyki?= , lintao , =?utf-8?B?6ZmI5aWL?= , =?utf-8?B?6LW15Luq5bOw?= , =?utf-8?B?6K645YmR576k?= , =?utf-8?B?6buE5rab?= , =?utf-8?B?6ZKf5YuH5rGq?= , =?utf-8?B?5aea5pm65oOF?= , "hj@Rock-chips.com" , =?utf-8?B?5p2o5Yev?= , =?utf-8?B?J+W8oOaZtCc=?= , "hl@rock-chips.com" List-ID: This is a multi-part message in MIME format. ------=_001_NextPart467682210521_=---- Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 U29ycnksIEkgd2lsbCByZXNlbmQgcGF0Y2ggcmlnaHQgbm93DQoNCg0KDQoNCg0KRnJvbTogTWFy ayBSdXRsYW5kDQpEYXRlOiAyMDE1LTAyLTA1IDE5OjI3DQpUbzogQWRkeSBLZQ0KQ0M6IHJvYmgr ZHRAa2VybmVsLm9yZzsgUGF3ZWwgTW9sbDsgaWpjK2RldmljZXRyZWVAaGVsbGlvbi5vcmcudWs7 IGdhbGFrQGNvZGVhdXJvcmEub3JnOyByZHVubGFwQGluZnJhZGVhZC5vcmc7IHRnaWguanVuQHNh bXN1bmcuY29tOyBqaDgwLmNodW5nQHNhbXN1bmcuY29tOyBjaHJpc0BwcmludGYubmV0OyB1bGYu aGFuc3NvbkBsaW5hcm8ub3JnOyBkaW5ndXllbkBhbHRlcmEuY29tOyBoZWlrb0BzbnRlY2guZGU7 IG9sb2ZAbGl4b20ubmV0OyBkaWFuZGVyc0BjaHJvbWl1bS5vcmc7IHNvbm55cmFvQGNocm9taXVt Lm9yZzsgYW1zdGFuQGNocm9taXVtLm9yZzsgZGV2aWNldHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxp bnV4LWRvY0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxp bnV4LW1tY0B2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZzsgbGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZzsgemhlbmZ1LmZhbmdAcm9j ay1jaGlwcy5jb207IGNmQHJvY2stY2hpcHMuY29tOyBsaW50YW9Acm9jay1jaGlwcy5jb207IGNo ZW5mZW5Acm9jay1jaGlwcy5jb207IHp5ZkByb2NrLWNoaXBzLmNvbTsgeGpxQHJvY2stY2hpcHMu Y29tOyBodWFuZ3Rhb0Byb2NrLWNoaXBzLmNvbTsgenl3QHJvY2stY2hpcHMuY29tOyB5enFAcm9j ay1jaGlwcy5jb207IGhqQHJvY2stY2hpcHMuY29tOyBrZXZlci55YW5nQHJvY2stY2hpcHMuY29t OyB6aGFuZ3FpbmdAcm9jay1jaGlwcy5jb207IGhsQHJvY2stY2hpcHMuY29tDQpTdWJqZWN0OiBS ZTogW1BBVENIXSBtbWM6IGNvcmU6IGFkZCBydW50aW1lLXJlc3VtZSBjYXBzIHRvIHN1cHBvcnQg cmVzdW1lIGF0IHJ1bnRpbWVfcmVzdW1lDQpPbiBUaHUsIEZlYiAwNSwgMjAxNSBhdCAxMTowNjo1 OUFNICswMDAwLCBBZGR5IEtlIHdyb3RlOg0KPiBTaWduZWQtb2ZmLWJ5OiBBZGR5IEtlIDxhZGR5 LmtlQHJvY2stY2hpcHMuY29tPg0KPiAtLS0NCj4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9tbWMvbW1jLnR4dCB8IDExICsrKysrKysrKysrDQo+ICBkcml2ZXJzL21tYy9jb3Jl L2hvc3QuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgMiArKw0KPiAgMiBmaWxlcyBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspDQo+IA0KPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL21tYy9tbWMudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL21tYy9tbWMudHh0DQo+IGluZGV4IDQzODg5OWUuLjMwM2I0NDggMTAwNjQ0DQo+IC0t LSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tbWMvbW1jLnR4dA0KPiArKysg Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbW1jL21tYy50eHQNCj4gQEAgLTQw LDkgKzQwLDIwIEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6DQo+ICAtIG1tYy1oczIwMC0xXzJ2OiBl TU1DIEhTMjAwIG1vZGUoMS4yViBJL08pIGlzIHN1cHBvcnRlZA0KPiAgLSBtbWMtaHM0MDAtMV84 djogZU1NQyBIUzQwMCBtb2RlKDEuOFYgSS9PKSBpcyBzdXBwb3J0ZWQNCj4gIC0gbW1jLWhzNDAw LTFfMnY6IGVNTUMgSFM0MDAgbW9kZSgxLjJWIEkvTykgaXMgc3VwcG9ydGVkDQo+ICstIHJ1bnRp bWUtcmVzdW1lOiByZXN1bWUgYXQgcnVudGltZV9yZXN1bWUgaXMgc3VwcG9ydGVkDQoNClRoaXMg cmVhZHMgbGlrZSBkZXNjcmlwdGlvbiBvZiBMaW51eCBpbnRlcm5hbHMgKHJ1bnRpbWVfcmVzdW1l KSwgd2hpY2gNCnNob3VsZG4ndCBiZSBpbiB0aGUgRFQuDQoNCldoYXQgZG9lcyB0aGlzIG1lYW4g YXQgdGhlIEhXIGxldmVsPyBJJ20gc3VyZSB3ZSBjYW4gZmluZCBhIGJldHRlciBuYW1lDQpmb3Ig dGhpcywgb3IgYW5vdGhlciB3YXkgb2YgZGVzY3JpYmluZyB0aGlzLg0KDQo+ICAtIGRzcjogVmFs dWUgdGhlIGNhcmQncyAob3B0aW9uYWwpIERyaXZlciBTdGFnZSBSZWdpc3RlciAoRFNSKSBzaG91 bGQgYmUNCj4gICAgcHJvZ3JhbW1lZCB3aXRoLiBWYWxpZCByYW5nZTogWzAgLi4gMHhmZmZmXS4N Cj4gIA0KPiArQ2FyZCBwb3dlciBhbmQgcmVzZXQgY29udHJvbDoNCj4gK1RoZSBmb2xsb3dpbmcg cHJvcGVydGllcyBjYW4gYmUgc3BlY2lmaWVkIGZvciBjYXNlcyB3aGVyZSB0aGUgTU1DDQo+ICtw ZXJpcGhlcmFsIG5lZWRzIGFkZGl0aW9uYWwgcmVzZXQsIHJlZ3VsYXRvciBhbmQgY2xvY2sgbGlu ZXMuIEl0IGlzIGZvcg0KPiArZXhhbXBsZSBjb21tb24gZm9yIFdpRmkvQlQgYWRhcHRlcnMgdG8g aGF2ZSB0aGVzZSBzZXBhcmF0ZSBmcm9tIHRoZSBtYWluDQo+ICtNTUMgYnVzOg0KPiArICAtIGNh cmQtcmVzZXQtZ3Bpb3M6IFNwZWNpZnkgR1BJT3MgZm9yIGNhcmQgcmVzZXQgKHJlc2V0IGFjdGl2 ZSBsb3cpDQo+ICsgIC0gY2FyZC1leHRlcm5hbC12Y2Mtc3VwcGx5OiBSZWd1bGF0b3IgdG8gZHJp dmUgKGluZGVwZW5kZW50KSBjYXJkIFZDQw0KPiArICAtIGNsb2NrIHdpdGggbmFtZSAiY2FyZF9l eHRfY2xvY2siOiBFeHRlcm5hbCBjbG9jayBwcm92aWRlZCB0byB0aGUgY2FyZA0KDQpBcmUgdGhl c2UgcHJvZXBydGllcyBwbGFjZWQgb24gdGhlIE1NQyBjb250cm9sbGVyIG5vZGUsIG9yIGEgc3Vi LW5vZGUNCnJlcHJlc2VudGluZyB0aGUgY2FyZC9zbG90Pw0KDQpUaGFua3MsDQpNYXJrLg== ------=_001_NextPart467682210521_=---- Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable =EF=BB=BF
Sorry, I will resend patch right now
 
 
Date: 2015-02-05 19:27
To: Addy Ke=
CC: robh+dt@kernel.= org;=20 Pawel Moll; ijc+devicetree@hellion.org.u= k;=20 galak@codeaurora.org; rdunlap@infradead.org; tgih.jun@samsung.com; jh80.chung@samsung.com; chris@printf.net; ulf.hansson@linaro.org; dinguyen@altera.com; heiko@sntech.de; olof@lixom.net; dianders@chromium.org; sonnyrao@chromium.org; amstan@chromium.org; devicetree@vger.kernel.org;= linux-doc@vger.kernel.org; <= A=20 href=3D"mailto:linux-kernel@vger.kernel.org">linux-kernel@vger.kernel.org<= /A>; linux-mmc@vger.kernel.org; <= A=20 href=3D"mailto:linux-arm-kernel@lists.infradead.org">linux-arm-kernel@list= s.infradead.org;=20 linux-rockchip@lists.in= fradead.org;=20 zhenfu.fang@rock-chips.com; cf@rock-chips.com; lintao@rock-chips.com; chenfen@rock-chips.com; zyf@rock-chips.com; xjq@rock-chips.com; huangtao@rock-chips.com; zyw@rock-chips.com; yzq@rock-chips.com; hj@rock-chips.com; kever.yang@rock-chips.com; <= A=20 href=3D"mailto:zhangqing@rock-chips.com">zhangqing@rock-chips.com; hl@rock-chips.com
Subject: Re: [PATCH] mmc: core: add runtime-resume caps t= o=20 support resume at runtime_resume
On Thu, Feb 05, 2015 at 11:06:59AM +0000, Addy Ke wrote:
> Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/mmc/mmc.txt | 11=20 +++++++++++
> =20 drivers/mmc/core/host.c        &nb= sp;            = ; =20 |  2 ++
>  2 files changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt=20 b/Documentation/devicetree/bindings/mmc/mmc.txt
> index 438899e..303b448 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/mmc.txt
> @@ -40,9 +40,20 @@ Optional properties:
>  - mmc-hs200-1_2v: eMMC HS200 mode(1.2V I/O) is supported
>  - mmc-hs400-1_8v: eMMC HS400 mode(1.8V I/O) is supported
>  - mmc-hs400-1_2v: eMMC HS400 mode(1.2V I/O) is supported
> +- runtime-resume: resume at runtime_resume is supported
 
This reads like description of Linux internals (runtime_resume),=20 which
shouldn't be in the DT.
 
What does this mean at the HW level? I'm sure we can find a better=20 name
for this, or another way of describing this.
 
>  - dsr: Value the card's (optional) Driver Stage Register (= DSR)=20 should be
>    programmed with. Valid range: [0 .. 0xffff].
> 
> +Card power and reset control:
> +The following properties can be specified for cases where the=20 MMC
> +peripheral needs additional reset, regulator and clock lines. I= t is=20 for
> +example common for WiFi/BT adapters to have these separate from= the=20 main
> +MMC bus:
> +  - card-reset-gpios: Specify GPIOs for card reset (reset = active=20 low)
> +  - card-external-vcc-supply: Regulator to drive (independ= ent)=20 card VCC
> +  - clock with name "card_ext_clock": External clock provi= ded to=20 the card
 
Are these proeprties placed on the MMC controller node, or a sub-node=
representing the card/slot?
 
Thanks,
Mark.
 
 
------=_001_NextPart467682210521_=------