Re: [PATCH 1/1] arm: Fix unavailable MTD userland devices on Excito B3 boards

Gordon Bos
2015-02-07T15:04:59Z

[-- Attachment #1: Type: text/plain, Size: 2831 bytes --]

Hi,

I've had some further discussion on this with another B3 owner.
According to an old patch that Excito corporation built for kernel
version 2.6 the flash memory is in fact a ||Numonyx MP25P16
The driver however must be m25p80.

It would therefore seem cleaner to just correct the driver reference
and leave the label as is. The patch thus becomes:

Signed-off-by: Gordon Bos <gordon@bosvangennip.nl>
---
arch/arm/boot/dts/kirkwood-b3.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
index c9247f8..5c6e8d3 100644
--- a/arch/arm/boot/dts/kirkwood-b3.dts
+++ b/arch/arm/boot/dts/kirkwood-b3.dts
@@ -74,7 +74,7 @@
m25p16@0 {
#address-cells = <1>;
#size-cells = <1>;
- compatible = "st,m25p16";
+ compatible = "st,m25p80";
reg = <0>;
spi-max-frequency = <40000000>;
mode = <0>;
---

Regards,
Gordon Bos

On 02/06/2015 10:09 AM, Gregory CLEMENT wrote:
> Hi Gordon,
>
>
> On 06/02/2015 09:45, Gordon Bos wrote:
>> Excito B3 boards use SPI flash for booting and several userland
>> functions require access to this flash memory, including power down
>> control. However /proc/mtd shows an empty list and the userland
>> tools respond with "device not found".
> The change in arm/boot/dts don't go through the device tree subsystem
> but through the arm-soc one. Especially it it is only a fix and if
> you don't introduce or modifying a binding. For this kind of patch
> you should cc the mvebu maintainers (I added the others one)
>
> However it seems that the get_maintainer.pl script is misleading on this
> point we should maybe be updating the MAINTAINERS file.
>
>> Change driver reference for spi@10600 to M25P80
>>
>> Verified on my own Excito B3
> This change looks OK for me however it is too late to merge it
> and it will be part of the next merge window.
>
> Andrew, as you initially wrote this dts would you have a look on it?
>
> As it is a fix we will also apply to the stable branches. It would
> help if you could tell us since when this bug is present.
>
>
> Thanks,
>
> Gregory
>
>
>> Signed-off-by: Gordon Bos <gordon@bosvangennip.nl>
>> ---
>> arch/arm/boot/dts/kirkwood-b3.dts | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
>> index c9247f8..4b1e414 100644
>> --- a/arch/arm/boot/dts/kirkwood-b3.dts
>> +++ b/arch/arm/boot/dts/kirkwood-b3.dts
>> @@ -71,10 +71,10 @@
>> spi@10600 {
>> status = "okay";
>>
>> - m25p16@0 {
>> + m25p80@0 {
>> #address-cells = <1>;
>> #size-cells = <1>;
>> - compatible = "st,m25p16";
>> + compatible = "st,m25p80";
>> reg = <0>;
>> spi-max-frequency = <40000000>;
>> mode = <0>;
>>
>

[-- Attachment #2: Type: text/html, Size: 3752 bytes --]