devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: tony@atomide.com, pali.rohar@gmail.com, pavel@ucw.cz,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering
Date: Mon, 9 Feb 2015 09:02:46 -0600	[thread overview]
Message-ID: <20150209150245.GC21362@kahuna> (raw)
In-Reply-To: <1423410536-16579-1-git-send-email-ivo.g.dimitrov.75@gmail.com>

On 17:48-20150208, Ivaylo Dimitrov wrote:
> With legacy boot i2c buses on Nokia N900 are numbered i2c1, i2c2 and i2c3.
> Commit 20b80942ef4e ("ARM: dts: OMAP3+: Add i2c aliases") fixed the
> numbering with DT boot, but introduced a regression on N900 - aliases
> become i2c0, i2c1 and i2c2. Fix that by providing the correct aliases in
> the board dts.
> 
> Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
> ---
I suppose this is due to some legacy userspace breakage?
if yes, we do not intend to break userspace :), So:
Acked-by: Nishanth Menon <nm@ti.com>

>  arch/arm/boot/dts/omap3-n900.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
> index b550c41..68bf3cd 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -16,6 +16,13 @@
>  	model = "Nokia N900";
>  	compatible = "nokia,omap3-n900", "ti,omap3430", "ti,omap3";
>  
> +	aliases {
> +		i2c0;
> +		i2c1 = &i2c1;
> +		i2c2 = &i2c2;
> +		i2c3 = &i2c3;
> +	};
> +
>  	cpus {
>  		cpu@0 {
>  			cpu0-supply = <&vcc>;
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Regards,
Nishanth Menon

  parent reply	other threads:[~2015-02-09 15:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-08 15:48 [PATCH] ARM: DTS: omap3-n900.dts: fix i2c bus numbering Ivaylo Dimitrov
2015-02-08 18:37 ` Pali Rohár
2015-02-09 15:02 ` Nishanth Menon [this message]
2015-02-09 16:03   ` Ivaylo Dimitrov
2015-02-24 18:02     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150209150245.GC21362@kahuna \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).