From: Lee Jones <lee.jones@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Jaewon Kim <jaewon02.kim@samsung.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org, Inki Dae <inki.dae@samsung.com>,
SangBae Lee <sangbae90.lee@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Sebastian Reichel <sre@kernel.org>,
Mark Brown <broonie@kernel.org>,
Beomho Seo <beomho.seo@samsung.com>
Subject: Re: [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver
Date: Mon, 16 Feb 2015 13:42:06 +0000 [thread overview]
Message-ID: <20150216134206.GH14545@x1> (raw)
In-Reply-To: <54D20A32.1020604@samsung.com>
On Wed, 04 Feb 2015, Chanwoo Choi wrote:
> On 02/04/2015 01:56 PM, Jaewon Kim wrote:
> > This patch adds MAX77843 core/irq driver to support PMIC,
> > MUIC(Micro USB Interface Controller), Charger, Fuel Gauge,
> > LED and Haptic device.
> >
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
> > Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> > ---
> > drivers/mfd/Kconfig | 14 ++
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/max77843.c | 245 +++++++++++++++++++
> > include/linux/mfd/max77843-private.h | 441 ++++++++++++++++++++++++++++++++++
> > 4 files changed, 701 insertions(+)
> > create mode 100644 drivers/mfd/max77843.c
> > create mode 100644 include/linux/mfd/max77843-private.h
<LOTS OF POINTLESS LINES OF UNCHANGED/UNREVIEWED CODE>
> Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Chanwoo,
If you're not going to make any comments, either put the Reviewed-by
at the top, or better still, snip out all of the bumph in the middle.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-02-16 13:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 4:56 [PATCH v3 0/6] Add new MFD driver for MAX77843 Jaewon Kim
2015-02-04 4:56 ` [PATCH v3 1/6] mfd: max77843: Add max77843 MFD driver core driver Jaewon Kim
2015-02-04 12:01 ` Chanwoo Choi
2015-02-16 13:42 ` Lee Jones [this message]
2015-02-16 13:48 ` Chanwoo Choi
2015-02-16 13:51 ` Lee Jones
2015-02-16 14:02 ` Krzysztof Kozłowski
2015-02-23 1:43 ` Jaewon Kim
2015-02-04 4:56 ` [PATCH v3 2/6] extcon: max77843: Add max77843 MUIC driver Jaewon Kim
2015-02-04 23:46 ` Chanwoo Choi
2015-02-04 4:56 ` [PATCH v3 3/6] power: max77843_charger: Add Max77843 charger device driver Jaewon Kim
2015-02-04 4:56 ` [PATCH v3 4/6] power: max77843_battery: Add Max77843 fuel gauge " Jaewon Kim
[not found] ` <1423025771-4139-1-git-send-email-jaewon02.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-04 4:56 ` [PATCH v3 5/6] regulator: max77843: Add max77843 regulator driver Jaewon Kim
2015-02-04 20:26 ` Mark Brown
2015-02-05 6:27 ` Jaewon Kim
2015-02-05 6:35 ` [PATCH v4] " Jaewon Kim
2015-02-05 17:36 ` Mark Brown
2015-02-04 4:56 ` [PATCH v3 6/6] Documentation: Add device tree bindings document for max77843 Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150216134206.GH14545@x1 \
--to=lee.jones@linaro.org \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sangbae90.lee@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).