Re: [PATCH/RFC] ARM: shmobile: lager: Fix audio clk master to SSI and change audio data interface format type

[Simon Horman <horms@verge.net.au>]

Hi Morimoto-san,

On Mon, Feb 16, 2015 at 12:01:15AM +0000, Kuninori Morimoto wrote:
> 
> Hi Kaneko-san, Simon
> 
> > >  arch/arm/boot/dts/r8a7790-lager.dts | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > > 
> > > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
> > > index 0c3b678..e7dda8a 100644
> > > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > > @@ -177,9 +177,7 @@
> > >  	sound {
> > >  		compatible = "simple-audio-card";
> > >  
> > > -		simple-audio-card,format = "left_j";
> > > -		simple-audio-card,bitclock-master = <&sndcodec>;
> > > -		simple-audio-card,frame-master = <&sndcodec>;
> > > +		simple-audio-card,format = "i2s";
> > >  
> > >  		sndcpu: simple-audio-card,cpu {
> > >  			sound-dai = <&rcar_sound>;
> 
> Unfortunately, I can't accept this patch.
> It will be strange sound if you change clk master to SSI (*1).
> Additionally, it needs audio_clk settings for SSI master,
> but, it needs special limitation (*1).
> (*1 HW connection reason)
> And format change left_j -> i2s is no meaning on Lager board case

Thanks for your analysis.
I am marking this patch as "rejected".