devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: devicetree@vger.kernel.org,
	Koen Kooi <koen@dominion.thruhere.net>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Ludovic Desroches <ludovic.desroches@atmel.com>,
	linux-arm-kernel@lists.infradead.org,
	Matt Porter <matt.porter@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH 3/4] arm: am33xx: DT quirks for am33xx based beaglebone variants
Date: Thu, 19 Feb 2015 10:36:00 -0800	[thread overview]
Message-ID: <20150219183600.GG32521@atomide.com> (raw)
In-Reply-To: <9C7BFC7C-0751-4233-927F-D01AF078704B@antoniou-consulting.com>

* Pantelis Antoniou <panto@antoniou-consulting.com> [150219 10:32]:
> > On Feb 19, 2015, at 20:16 , Tony Lindgren <tony@atomide.com> wrote:
> > 
> > Uhh I don't like the idea of duplicating the i2c-omap.c driver under
> > arch/arm.. And in general we should initialize things later rather
> > than earlier.
> > 
> > What's stopping doing these quirk checks later on time with just
> > a regular device driver, something like drivers/misc/bbone-quirks.c?
> > 
> 
> We have no choice; we are way early in the boot process, right after
> the device tree unflattening step.

To me it seems the dt patching part should be done with minimal
code before any driver like features..
 
> I’ve toyed with the idea of using early platform devices but the omap-i2c driver
> would need some tender love and care to make it work, and I didn’t want to get
> bogged down with i2c driver details at this point.

..so how about just parse a kernel cmdline for the quirks to apply
based on a version string or similar? That can be easily populated
by u-boot or set manually with setenv.

That leaves out the need for tinkering with i2c super early in
the kernel for revision detection.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2015-02-19 18:36 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-18 14:59 [PATCH 0/4] Device Tree Quirks & the Beaglebone Pantelis Antoniou
2015-02-18 14:59 ` [PATCH 1/4] arm: of: Add a DT quirk method after unflattening Pantelis Antoniou
2015-02-18 14:59 ` [PATCH 2/4] of: DT quirks infrastructure Pantelis Antoniou
     [not found]   ` <1424271576-1952-3-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-02-18 15:41     ` Mark Rutland
2015-02-18 15:53       ` Pantelis Antoniou
2015-02-18 16:32         ` Ludovic Desroches
2015-02-18 16:39           ` Pantelis Antoniou
     [not found]             ` <A5D4ED10-F3EB-4DA8-A846-C28842BDAA9F-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-02-18 16:47               ` Ludovic Desroches
     [not found]         ` <FE61DD1C-51DA-4869-8A62-C019C3D70577-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-02-18 16:46           ` Matt Porter
2015-02-18 17:31         ` Mark Rutland
2015-02-18 19:32           ` Guenter Roeck
2015-02-19 14:29           ` Pantelis Antoniou
2015-02-19 16:48             ` Frank Rowand
     [not found]               ` <54E613E7.2020405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-19 17:00                 ` Pantelis Antoniou
2015-02-19 17:30                   ` Frank Rowand
2015-02-19 17:38                     ` Pantelis Antoniou
2015-02-19 18:01                       ` Maxime Bizon
     [not found]                         ` <1424368919.13604.9.camel-MdnFuL0m/hCw+z8RR+d9WEZ2mhrpEnA6@public.gmane.org>
2015-02-19 18:12                           ` Sylvain Rochet
2015-02-19 18:22                             ` Maxime Bizon
2015-02-20 14:21                       ` Peter Hurley
     [not found]                         ` <54E742F2.80506-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-02-20 14:35                           ` Ludovic Desroches
     [not found]                             ` <20150220143533.GA29908-FuRPzXQv2LUWBfJKYY8PcdBPR1lH4CV8@public.gmane.org>
2015-02-20 15:00                               ` Peter Hurley
2015-02-20 15:02                                 ` Pantelis Antoniou
2015-02-20 15:24                                   ` Peter Hurley
2015-02-20 15:38                                     ` Pantelis Antoniou
2015-02-20 16:34                                       ` Peter Hurley
2015-02-20 16:49                                         ` Pantelis Antoniou
2015-02-20 17:30                             ` Rob Herring
2015-02-20 17:37                               ` Pantelis Antoniou
2015-02-23  7:00                               ` Ludovic Desroches
2015-02-20 16:47                           ` Guenter Roeck
2015-02-20 18:09                             ` Peter Hurley
     [not found]                               ` <54E77876.9020500-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org>
2015-02-20 18:48                                 ` Guenter Roeck
     [not found]                                   ` <20150220184818.GC26698-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-02-23  7:30                                     ` Ludovic Desroches
2015-02-20 14:38                         ` Pantelis Antoniou
2015-02-20  8:04                     ` Ludovic Desroches
2015-02-19  2:08   ` Frank Rowand
2015-02-19 14:41     ` Pantelis Antoniou
2015-02-19 16:40       ` Frank Rowand
     [not found]         ` <54E61200.4010002-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-19 16:51           ` Frank Rowand
2015-02-20 13:23       ` Peter Hurley
     [not found]     ` <54E54586.5070602-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-02-19 18:01       ` Rob Herring
2015-02-19 18:12         ` Guenter Roeck
     [not found]         ` <CAL_JsqKT3+URcad6X=i+73NLRnVstbpvFJxxT=ru7KJmp_XuVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-20  8:16           ` Ludovic Desroches
2015-02-18 14:59 ` [PATCH 3/4] arm: am33xx: DT quirks for am33xx based beaglebone variants Pantelis Antoniou
2015-02-19 18:16   ` Tony Lindgren
2015-02-19 18:28     ` Pantelis Antoniou
2015-02-19 18:36       ` Tony Lindgren [this message]
     [not found]         ` <20150219183600.GG32521-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2015-02-19 18:44           ` Pantelis Antoniou
2015-02-23 18:39             ` Peter Hurley
2015-02-23 18:48               ` Pantelis Antoniou
2015-02-19 18:57         ` Guenter Roeck
2015-02-20 16:13       ` Jon Hunter
     [not found] ` <1424271576-1952-1-git-send-email-pantelis.antoniou-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
2015-02-18 14:59   ` [PATCH 4/4] arm: dts: Common Black/White Beaglebone DTS using quirks Pantelis Antoniou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219183600.GG32521@atomide.com \
    --to=tony@atomide.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@secretlab.ca \
    --cc=koen@dominion.thruhere.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=ludovic.desroches@atmel.com \
    --cc=matt.porter@linaro.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=panto@antoniou-consulting.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).