From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine driver support Date: Fri, 20 Feb 2015 11:59:34 +0530 Message-ID: <20150220062934.GX21387@intel.com> References: <1413374436-14410-1-git-send-email-sthokal@xilinx.com> <3236720.MHeqOodrCV@wuerfel> <7dc11ef7ccec49bcb052c30b9aa916c3@BL2FFO11FD044.protection.gbl> <1967130.oYyZRWCcEF@wuerfel> <20150212093445.GM21387@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Appana Durga Kedareswara Rao Cc: Arnd Bergmann , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Srikanth Vemula , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Srikanth Thokala , "dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Michal Simek , Anirudha Sarangi , "grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org" , "dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org" List-Id: devicetree@vger.kernel.org On Sat, Feb 14, 2015 at 02:21:52PM +0000, Appana Durga Kedareswara Rao wrote: > Hi Vinod, > > > > -----Original Message----- > > From: Vinod Koul [mailto:vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org] > > Sent: Thursday, February 12, 2015 3:05 PM > > To: Appana Durga Kedareswara Rao > > Cc: Arnd Bergmann; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; > > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Srikanth Vemula; linux- > > kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Srikanth Thokala; dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > > robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; Michal Simek; Anirudha Sarangi; > > grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org > > Subject: Re: [PATCH v4] dma: Add Xilinx AXI Direct Memory Access Engine > > driver support > > > > On Thu, Jan 29, 2015 at 11:24:41AM +0000, Appana Durga Kedareswara Rao > > wrote: > > > > Earlier in the driver we are embedding dma_slave_config into custom > > > > structs But Lars suggested to modify it. please refer to the below > > > > thread for more details. > > > > http://www.spinics.net/lists/dmaengine/msg00010.html > > > > > > > > And later we thought of creating a separate private member in > > > > dma_slave_config for sharing additional configuration between slave > > > > device and dma engine Or a new dma_ctrl_cmd like > > > > > > FSLDMA_EXTERNAL_START(http://www.kernelhub.org/?msg=405535&p=2 ) > > > > > > > > Finally Vinod was ok with the existing suggestion so we dropped the > > > > above thought. > > > > > > > > @Vinod : Could you please comment on this. > > FSLDMA_EXTERNAL_START has been removed, and you cna use the removal > > as a guidance of how to solve your issue > > > Please limit you mailer to set wrap at 80 chars, otherwise it becomes unreadable > The current VDMA driver that got merged in the open source and the > current patch (dma: xilinx dma v4) Srikanth T submitted both contains the > Similar implementation that you pointed as above(I mean similar to the > free scale dma driver). > > The discussion starts here is why we need the header file(Xilinx_dma.h) in > the include/linux/amba/Xilinx_dma.h folder. > > Like for FSL DMA it is got defined (fsl_dma_external_start) as a function > prototype in include/linux/fsldma.h And it is being getting used in the > drivers/misc/carma/carma-fpga-program.c > > Similarly in the Xilinx VDMA driver(xilinx_vdma_channel_set_config ) > defined as a function prototype in the include/linux/amba/xilinx_dma.h And > is being used by Xilinx videos drivers. Those video driver need to use > the (xilinx_vdma_channel_set_config) which requires this global header > file. > > Could you please suggest us whether that header file (Xilinx_dma.h) should > be there in include/linux/amba or we should move it to include/linux? > And any functional comments for this v4 patch? Let me ask you a question, what is the relation of xilinx_dma with amba? If none then only include/linux/ seems to be the right choice. If not then amba maybe okay but you need to provide justfication why it should be in amba? -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html