From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lee.jones@linaro.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.ok,
galak@codeaurora.org, sameo@linux.intel.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] mfd: arizona: Move useful defines into a dt-binding include
Date: Sat, 21 Feb 2015 10:23:41 +0000 [thread overview]
Message-ID: <20150221102341.GA15374@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20150221092308.GC6236@finisterre.sirena.org.uk>
On Sat, Feb 21, 2015 at 06:23:08PM +0900, Mark Brown wrote:
> On Wed, Feb 18, 2015 at 11:03:39AM +0000, Charles Keepax wrote:
>
> > --- a/include/linux/mfd/arizona/pdata.h
> > +++ b/include/linux/mfd/arizona/pdata.h
> > @@ -7,61 +7,17 @@
> > * it under the terms of the GNU General Public License version 2 as
> > * published by the Free Software Foundation.
> > */
> > +#include <dt-bindings/mfd/arizona.h>
> >
> > #ifndef _ARIZONA_PDATA_H
> > #define _ARIZONA_PDATA_H
>
> It's a bit odd to have the include outside the guards, is there any
> great reason for doing so?
There is not, simple error on my part, I will respin and move it inside.
Thanks,
Charles
next prev parent reply other threads:[~2015-02-21 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 11:03 [PATCH] mfd: arizona: Move useful defines into a dt-binding include Charles Keepax
[not found] ` <1424257419-28000-1-git-send-email-ckeepax-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2015-02-21 9:23 ` Mark Brown
2015-02-21 10:23 ` Charles Keepax [this message]
2015-02-23 16:00 ` Rob Herring
[not found] ` <CAL_JsqJwOD+BtFK=UZ+4smy4FN_8N2ATWXj+it2giRejsxD_hw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-02-24 22:46 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150221102341.GA15374@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.ok \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).