From: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Shawn Guo <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Matt Porter <mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ARM Kernel List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances
Date: Tue, 3 Mar 2015 12:43:36 +0800 [thread overview]
Message-ID: <20150303044334.GA16617@shlinux2> (raw)
In-Reply-To: <20150303034133.GJ20455@dragon>
On Tue, Mar 03, 2015 at 11:41:35AM +0800, Shawn Guo wrote:
>
> On Fri, Feb 27, 2015 at 09:06:00AM -0500, Matt Porter wrote:
> > The chipidea driver adds an extra line of spam to the log when a
> > host-only chipidea instance is left set to the default of a dual role
> > controller.
> >
> > [ 2.010873] ci_hdrc ci_hdrc.1: doesn't support gadget
> >
> > Set the dr_mode property to host on all the host-only nodes
> > to avoid this warning.
It is not an warning, it is dev_info.
In fact, imx28, imx6sl and imx6sx's second controller is dual-role
controller, we only set dr_mode at board's dts according to design
unless the controller's capability register is incorrect.
So, sorry, I don't think this change is necessary.
> >
> > Signed-off-by: Matt Porter <mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org>
> > ---
> > arch/arm/boot/dts/imx27.dtsi | 2 ++
> > arch/arm/boot/dts/imx28.dtsi | 1 +
> > arch/arm/boot/dts/imx35.dtsi | 1 +
> > arch/arm/boot/dts/imx50.dtsi | 3 +++
> > arch/arm/boot/dts/imx51.dtsi | 3 +++
> > arch/arm/boot/dts/imx53.dtsi | 3 +++
> > arch/arm/boot/dts/imx6qdl.dtsi | 3 +++
> > arch/arm/boot/dts/imx6sl.dtsi | 1 +
> > arch/arm/boot/dts/imx6sx.dtsi | 1 +
> > 9 files changed, 18 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx27.dtsi b/arch/arm/boot/dts/imx27.dtsi
> > index 4b063b6..6951b66 100644
> > --- a/arch/arm/boot/dts/imx27.dtsi
> > +++ b/arch/arm/boot/dts/imx27.dtsi
> > @@ -488,6 +488,7 @@
> > interrupts = <54>;
> > clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
> > fsl,usbmisc = <&usbmisc 1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -497,6 +498,7 @@
> > interrupts = <55>;
> > clocks = <&clks IMX27_CLK_USB_IPG_GATE>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 47f68ac..02330f4 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -1197,6 +1197,7 @@
> > interrupts = <92>;
> > clocks = <&clks 61>;
> > fsl,usbphy = <&usbphy1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx35.dtsi b/arch/arm/boot/dts/imx35.dtsi
> > index 6932928..b6478e9 100644
> > --- a/arch/arm/boot/dts/imx35.dtsi
> > +++ b/arch/arm/boot/dts/imx35.dtsi
> > @@ -318,6 +318,7 @@
> > clocks = <&clks 73>;
> > fsl,usbmisc = <&usbmisc 1>;
> > fsl,usbphy = <&usbphy1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
> > index 620b0f0..e245713 100644
> > --- a/arch/arm/boot/dts/imx50.dtsi
> > +++ b/arch/arm/boot/dts/imx50.dtsi
> > @@ -197,6 +197,7 @@
> > reg = <0x53f80200 0x0200>;
> > interrupts = <14>;
> > clocks = <&clks IMX5_CLK_USB_PHY2_GATE>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -205,6 +206,7 @@
> > reg = <0x53f80400 0x0200>;
> > interrupts = <16>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -213,6 +215,7 @@
> > reg = <0x53f80600 0x0200>;
> > interrupts = <17>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> > index c0116cf..f46fe9b 100644
> > --- a/arch/arm/boot/dts/imx51.dtsi
> > +++ b/arch/arm/boot/dts/imx51.dtsi
> > @@ -265,6 +265,7 @@
> > interrupts = <14>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -274,6 +275,7 @@
> > interrupts = <16>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -283,6 +285,7 @@
> > interrupts = <17>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 3>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> > index ff4fa7e..c3e3ca9 100644
> > --- a/arch/arm/boot/dts/imx53.dtsi
> > +++ b/arch/arm/boot/dts/imx53.dtsi
> > @@ -309,6 +309,7 @@
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 1>;
> > fsl,usbphy = <&usbphy1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -318,6 +319,7 @@
> > interrupts = <16>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -327,6 +329,7 @@
> > interrupts = <17>;
> > clocks = <&clks IMX5_CLK_USBOH3_GATE>;
> > fsl,usbmisc = <&usbmisc 3>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
> > index d6c69ec..9347c93 100644
> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
> > @@ -845,6 +845,7 @@
> > clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > fsl,usbphy = <&usbphy2>;
> > fsl,usbmisc = <&usbmisc 1>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -854,6 +855,7 @@
> > interrupts = <0 41 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > @@ -863,6 +865,7 @@
> > interrupts = <0 42 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks IMX6QDL_CLK_USBOH3>;
> > fsl,usbmisc = <&usbmisc 3>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> > index 36ab8e0..9bf1db3 100644
> > --- a/arch/arm/boot/dts/imx6sl.dtsi
> > +++ b/arch/arm/boot/dts/imx6sl.dtsi
> > @@ -699,6 +699,7 @@
> > interrupts = <0 40 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks IMX6SL_CLK_USBOH3>;
> > fsl,usbmisc = <&usbmisc 2>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> > index 7a24fee..fdadd060 100644
> > --- a/arch/arm/boot/dts/imx6sx.dtsi
> > +++ b/arch/arm/boot/dts/imx6sx.dtsi
> > @@ -763,6 +763,7 @@
> > fsl,usbmisc = <&usbmisc 2>;
> > phy_type = "hsic";
> > fsl,anatop = <&anatop>;
> > + dr_mode = "host";
> > status = "disabled";
> > };
> >
> > --
> > 1.8.4
> >
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-03-03 4:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 14:06 [PATCH] ARM: dts: imx: Add dr_mode host setting to all host-only usb instances Matt Porter
2015-03-03 3:41 ` Shawn Guo
2015-03-03 4:43 ` Peter Chen [this message]
2015-03-03 15:08 ` Matt Porter
2015-03-04 0:51 ` Peter Chen
2015-03-06 4:40 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150303044334.GA16617@shlinux2 \
--to=peter.chen-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mporter-OWPKS81ov/FWk0Htik3J/w@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).