Re: Re: [PATCH] ARM: sun6i: dt: Add new Mele I7 device

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]

On Tue, Mar 03, 2015 at 08:55:36AM +0100, Hans de Goede wrote:
> >>+/ {
> >>+	model = "Mele I7 Quad top set box";
> >>+	compatible = "mele,i7", "allwinner,sun6i-a31";
> >>+
> >>+	chosen {
> >>+		bootargs = "earlyprintk console=ttyS0,115200";
> >
> >Using earlyprintk by default is a bad idea if the kernel is configured
> >with DEBUG_LL support for another SoC.
> 
> While on this subject, u-boot now sets the chosen/stdout-path property
> up by default, which means that the kernel will do the right thing by
> default. So we we really do not need any bootargs= in our dts files.

I just tested that this weekend, and it turned out that the kernel
couldn't use it so far (ie, no output until init takes over and setup
a TTY on ttyS0).

Was it working for you?

> Currently we've a random mix where we do have bootargs in some, but
> not in most sunxi dts files. I believe we should simply remove it
> everywhere...

We used to set them in SoCs that are not supported by U-boot yet, and
where the bootloader won't come and patch the DT (A31, A23, A80).

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com