From: Aleksei Mamlin <mamlinav@gmail.com>
To: Antonio Ospite <ao2@ao2.it>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Bastien Nocera <hadess@hadess.net>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 2/2] input: goodix: Add device tree support for 5-finger chips
Date: Wed, 4 Mar 2015 13:55:08 +0300 [thread overview]
Message-ID: <20150304135508.d54656131ed7f6e22c3cb7df@gmail.com> (raw)
In-Reply-To: <20150304113040.014ca7f2c14c65b5f7e9672c@ao2.it>
On Wed, 4 Mar 2015 11:30:40 +0100
Antonio Ospite <ao2@ao2.it> wrote:
> On Wed, 4 Mar 2015 11:34:13 +0300
> Aleksei Mamlin <mamlinav@gmail.com> wrote:
>
> > This patch adds device tree support for 5-finger chips, like GT911 and GT912.
> >
>
> Hi Aleksei,
>
> from a datasheet I found[1](Pag. 11) I see that some devices provide
> the information about the max number of touch points in register 0x804C.
>
> Have you tried if this is true on your 5-finger devices too?
> If so, please use this mechanism to populate ts->max_touch_num to avoid
> passing hardcoded data.
>
Hi Antonio,
I checked datasheets and you are right, seems that all Goodix GT9xx series provides max number of touch points in register 0x804C.
I'll rewrite driver to use data from 0x804C register.
> Thanks,
> Antonio
>
> [1] http://www.wpgholdings.com/uploads/bu/bu_3/MID_20141112/GT9271_Datasheet_20130904.pdf
>
> --
> Antonio Ospite
> http://ao2.it
>
> A: Because it messes up the order in which people normally read text.
> See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?
--
Thanks and regards,
Aleksei Mamlin
next prev parent reply other threads:[~2015-03-04 10:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 8:32 [PATCH 0/2] Add device tree support for Goodix GT9xx series touchscreen controller Aleksei Mamlin
2015-03-04 8:33 ` [PATCH 1/2] input: goodix: Add device tree support Aleksei Mamlin
2015-03-04 9:21 ` Bastien Nocera
2015-03-04 17:12 ` Antonio Ospite
2015-03-04 8:34 ` [PATCH 2/2] input: goodix: Add device tree support for 5-finger chips Aleksei Mamlin
[not found] ` <1425458053-4559-1-git-send-email-mamlinav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-04 9:19 ` Bastien Nocera
[not found] ` <1425460748.9384.2.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>
2015-03-04 17:53 ` Aleksei Mamlin
2015-03-04 10:30 ` Antonio Ospite
2015-03-04 10:55 ` Aleksei Mamlin [this message]
2015-03-05 16:18 ` [PATCH v2] input: goodix: Add device tree support Aleksei Mamlin
2015-03-05 16:32 ` Bastien Nocera
2015-03-05 16:36 ` Benjamin Tissoires
2015-03-05 17:32 ` [PATCH] input: goodix: Use max touch number from device config Aleksei Mamlin
2015-03-06 12:19 ` Bastien Nocera
2015-03-06 13:42 ` Antonio Ospite
2015-03-07 0:41 ` Dmitry Torokhov
2015-03-05 17:32 ` [PATCH v3] input: goodix: Add device tree support Aleksei Mamlin
2015-03-06 12:23 ` Bastien Nocera
2015-03-07 0:47 ` Dmitry Torokhov
2015-03-06 13:53 ` Antonio Ospite
2015-03-06 14:18 ` Aleksei Mamlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304135508.d54656131ed7f6e22c3cb7df@gmail.com \
--to=mamlinav@gmail.com \
--cc=ao2@ao2.it \
--cc=devicetree@vger.kernel.org \
--cc=hadess@hadess.net \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).