From: Simon Horman <horms@verge.net.au>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Ulrich Hecht <ulrich.hecht+renesas@gmail.com>,
linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up
Date: Thu, 5 Mar 2015 09:34:33 +0900 [thread overview]
Message-ID: <20150305003432.GA3011@verge.net.au> (raw)
In-Reply-To: <1425059319-13403-1-git-send-email-geert+renesas@glider.be>
On Fri, Feb 27, 2015 at 06:48:37PM +0100, Geert Uytterhoeven wrote:
> Hi Simon, Magnus,
>
> This patch series adds the missing pull-up bias configuration for the
> switches on the r8a73a4/ape6evm development board, and configures the
> custom switch as a wake-up source.
>
> After this, the keys actually work, and the system can be resumed from
> s2ram by pressing the custom switch.
>
> This depends functionally on "[PATCH 1/4] pinctrl: sh-pfc: Do not
> overwrite bias configuration" in the series "[PATCH 0/4] pinctrl:
> sh-pfc: Fix pin bias and cleanups" which I've just sent. But as this is
> DTS, it can be applied independently.
>
> Thanks for your comments!
Hi Geert,
this seems fine to me. But I am reluctant to queue it up before the PFC
changes are accepted, lest there be some change in direction.
Please repost once the PFC changes have been accepted.
next prev parent reply other threads:[~2015-03-05 0:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 17:48 [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up Geert Uytterhoeven
2015-02-27 17:48 ` [PATCH 1/2] ARM: shmobile: ape6evm dts: Enable pull-up for GPIO switches Geert Uytterhoeven
2015-02-27 17:48 ` [PATCH 2/2] ARM: shmobile: ape6evm dts: Configure the custom switch as wake-up source Geert Uytterhoeven
2015-03-05 0:34 ` Simon Horman [this message]
2015-03-05 10:42 ` [PATCH 0/2] ARM: shmobile: ape6evm: Fix GPIO keys and wake-up Laurent Pinchart
2015-03-06 11:30 ` Simon Horman
2015-03-06 11:33 ` Laurent Pinchart
2015-03-07 1:08 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150305003432.GA3011@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulrich.hecht+renesas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).