devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Beomho Seo <beomho.seo@samsung.com>
Cc: broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	lee.jones@linaro.org, cw00.choi@samsung.com,
	sangbae90.lee@samsung.com, inki.dae@samsung.com,
	sw0312.kim@samsung.com,
	Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver
Date: Mon, 9 Mar 2015 11:10:12 +0100	[thread overview]
Message-ID: <20150309101012.GA3914@earth> (raw)
In-Reply-To: <54FD2766.2090401@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 804 bytes --]

Hi,

On Mon, Mar 09, 2015 at 01:53:58PM +0900, Beomho Seo wrote:
> >> remove the special handling of POWER_SUPPLY_PROP_CURRENT_MAX in 
> >> rt5033_get_charger_current() and do it like this:
> >>
> >> case POWER_SUPPLY_PROP_CURRENT_NOW:
> >>     val->intval = rt5033_get_charger_current(charger);
> >>     break;
> >> case POWER_SUPPLY_PROP_CURRENT_MAX:
> >>     val->intval = RT5033_CHG_MAX_CURRENT;
> >>     break;
> >>
> > 
> > OK. I will change comply with your comment.
> > 
> 
> RT5033_CHG_MAX_CURRENT is register value(hex).
> So It is better:
> 
> case POWER_SUPPLY_PROP_CURRENT_MAX:
> 	val->intval = RT5033_CHARGER_FAST_CURRENT_MAX;
> 
> And then I will fix rt5033_get_charger_current function more readable.

Right, I copied the wrong value.

> [...]

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-03-09 10:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09  1:23 [PATCH v5 0/2] power: rt5033: Add Richtek RT533 drivers Beomho Seo
2015-03-09  1:23 ` [PATCH v5 1/2] power: rt5033_charger: Add RT5033 charger device driver Beomho Seo
2015-03-09  1:50   ` Sebastian Reichel
2015-03-09  3:46     ` Beomho Seo
2015-03-09  4:53       ` Beomho Seo
2015-03-09 10:10         ` Sebastian Reichel [this message]
2015-03-11 11:06   ` Paul Bolle
2015-03-11 11:20     ` Beomho Seo
2015-03-09  1:23 ` [PATCH 2/2] Documentation: Add documentation for rt5033 multifunction device Beomho Seo
2015-03-09  7:43   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150309101012.GA3914@earth \
    --to=sre@kernel.org \
    --cc=beomho.seo@samsung.com \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=inki.dae@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sangbae90.lee@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).