From: Sebastian Reichel <sre@kernel.org>
To: Moritz Fischer <moritz.fischer@ettus.com>
Cc: dbaryshkov@gmail.com, dwmw2@infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCHv2 1/2] power: reset: Add generic SYSCON register mapped poweroff.
Date: Thu, 12 Mar 2015 00:48:40 +0100 [thread overview]
Message-ID: <20150311234839.GA21023@earth> (raw)
In-Reply-To: <1426113145-2921-2-git-send-email-moritz.fischer@ettus.com>
[-- Attachment #1: Type: text/plain, Size: 551 bytes --]
Hi Moritz,
On Wed, Mar 11, 2015 at 03:32:24PM -0700, Moritz Fischer wrote:
> [...]
> +static struct platform_driver syscon_poweroff_driver = {
> + .probe = syscon_poweroff_probe,
> + .remove = syscon_poweroff_remove,
> + .driver = {
> + .name = "syscon-poweroff",
> + .of_match_table = of_match_ptr(syscon_poweroff_of_match),
Sorry if it was unclear from my previous message - of_match_ptr() is
only needed for optional OF support. Since you removed the #ifdef
around syscon_poweroff_of_match, of_match_ptr() is not needed.
> [...]
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-11 23:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 22:32 [PATCHv2 0/2] Add support for generic register mapped poweroff Moritz Fischer
2015-03-11 22:32 ` [PATCHv2 1/2] power: reset: Add generic SYSCON " Moritz Fischer
2015-03-11 23:48 ` Sebastian Reichel [this message]
2015-03-11 22:32 ` [PATCHv2 2/2] dt: power: Add docs for generic SYSCON poweroff driver Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311234839.GA21023@earth \
--to=sre@kernel.org \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=moritz.fischer@ettus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).