From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 1/2] Documentation: devicetree: m25p80: add "nor-jedec" binding Date: Thu, 12 Mar 2015 10:53:52 +0000 Message-ID: <20150312105352.GC30145@leverpostej> References: <1426111046-29900-1-git-send-email-computersforpeace@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Geert Uytterhoeven , Brian Norris , MTD Maling List , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ezequiel Garcia , Marek Vasut List-Id: devicetree@vger.kernel.org On Thu, Mar 12, 2015 at 10:36:29AM +0000, Rafa=C5=82 Mi=C5=82ecki wrote= : > On 12 March 2015 at 11:19, Geert Uytterhoeven = wrote: > > On Wed, Mar 11, 2015 at 10:57 PM, Brian Norris > > wrote: > >> diff --git a/Documentation/devicetree/bindings/mtd/m25p80.txt b/Do= cumentation/devicetree/bindings/mtd/m25p80.txt > >> index 4611aa83531b..1b2997d4cee4 100644 > >> --- a/Documentation/devicetree/bindings/mtd/m25p80.txt > >> +++ b/Documentation/devicetree/bindings/mtd/m25p80.txt > >> @@ -3,9 +3,12 @@ > >> Required properties: > >> - #address-cells, #size-cells : Must be present if the device has= sub-nodes > >> representing partitions. > >> -- compatible : Should be the manufacturer and the name of the chi= p. Bear in mind > >> +- compatible : Should be "nor-jedec" for any SPI NOR flash that c= an be > >> + identified by the JEDEC READ ID opcode (0x95). > >> + Additionally, may include a device-specific string= consisting of > >> + the manufacturer and name of the chip. Bear in min= d > > > > For the casual reader, this suggests putting "nor-jedec" first, whi= ch is not > > what we want. So I would write it like e.g. > > > > "Should be the manufacturer and the name of the chip. Additionally, > > should contain "nor-jedec" for any SPI NOR flash that can be > > identified by the JEDEC READ ID opcode (0x95)." >=20 > I don't really like above. It suggests using manufacturer,name > always/in most cases. This is what we want to avoid. Let's use > "nor-jedec" wherever possible (when dealing with JEDEC compatible > flashes). The compatible property is a list. We should have "nor-jedec" in the list, but a more specific string should come first. If we don't recognise the more specific string, we'll still recognise nor-jedec, if we do recognise it then we can do more advacned things with the HW (or work around errata). Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html